linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chen Yang <chenyang.fnst@cn.fujitsu.com>
To: Alex Lyakas <alex.btrfs@zadarastorage.com>
Cc: Alexander Block <ablock84@googlemail.com>,
	Jan Schmidt <list.btrfs@jan-o-sch.net>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	Arne Jansen <sensille@gmx.net>
Subject: Re: [PATCH 0/2] send: Avoid sending disknr==0 and PREALLOC extents when possible
Date: Thu, 10 Jan 2013 11:25:06 +0800	[thread overview]
Message-ID: <50EE3492.4030704@cn.fujitsu.com> (raw)
In-Reply-To: <CAOcd+r1VfBCRmDptpp47CLDAbH-o+NpAQxx42ou5JVG-hfM0PA@mail.gmail.com>

Hi, Alex
The patches can only solve part of questions, but some like "punch holes" problems 
as Alexander wrote are still unsolved. So I think these patches are unnecessary
if adding new command would help to solve all the questions.

Chen.

On 2013-1-9 4:11, Alex Lyakas wrote:
> These two patches address the issue of sending unneeded zero data for
> disknr==0 and PREALLOC extents.
> There is room for additional improvement for PREALLOC extents, but it
> requires adding a new command, so for
> now this is not addressed.
> 
> Please review and comment.
> 
> Thanks,
> Alex.
> 
> Alex Lyakas (2):
>   Avoid sending disknr==0 extents in the following cases:     1) full
>     send 2) new inode in a diff-send 3) when disknr==0 extents are
>     added to the end of an inode
>   On a diff-send, avoid sending PREALLOC extents, if the parent root
>     has only     PREALLOC extents on an appropriate file range.
> 
>  fs/btrfs/send.c |  178 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 172 insertions(+), 6 deletions(-)
> 
> --
> 1.7.9.5
> 


  parent reply	other threads:[~2013-01-10  3:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-09 17:37 [PATCH 0/2] send: Avoid sending disknr==0 and PREALLOC extents when possible Alex Lyakas
2013-01-09 17:39 ` [PATCH 1/2] Avoid sending disknr==0 " Alex Lyakas
2013-01-09 17:41 ` [PATCH 2/2] On a diff-send, avoid sending PREALLOC extent Alex Lyakas
2013-01-14 18:45   ` Josef Bacik
2013-01-21 10:33     ` Alex Lyakas
2013-01-10  3:25 ` Chen Yang [this message]
2013-01-10  8:46   ` [PATCH 0/2] send: Avoid sending disknr==0 and PREALLOC extents when possible Alex Lyakas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EE3492.4030704@cn.fujitsu.com \
    --to=chenyang.fnst@cn.fujitsu.com \
    --cc=ablock84@googlemail.com \
    --cc=alex.btrfs@zadarastorage.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=list.btrfs@jan-o-sch.net \
    --cc=sensille@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).