From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-btrfs-owner@vger.kernel.org>
Received: from eastrmfepo201.cox.net ([68.230.241.216]:60446 "EHLO
	eastrmfepo201.cox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755645Ab3AUOLm (ORCPT
	<rfc822;linux-btrfs@vger.kernel.org>);
	Mon, 21 Jan 2013 09:11:42 -0500
Received: from eastrmimpo109 ([68.230.241.222]) by eastrmfepo201.cox.net
          (InterMail vM.8.01.04.00 201-2260-137-20101110) with ESMTP
          id <20130121141141.IDOG17456.eastrmfepo201.cox.net@eastrmimpo109>
          for <linux-btrfs@vger.kernel.org>;
          Mon, 21 Jan 2013 09:11:41 -0500
Message-ID: <50FD4C95.6020504@czarc.net>
Date: Mon, 21 Jan 2013 09:11:33 -0500
From: Gene Czarcinski <gene@czarc.net>
MIME-Version: 1.0
To: linux-btrfs@vger.kernel.org
CC: Wang Shilong <wangsl-fnst@cn.fujitsu.com>, Miao Xie <miaox@cn.fujitsu.com>
Subject: Re: [PATCH 12/13] Btrfs-progs: disable qgroupid 0 for quota_tree
References: <1358715858-4469-1-git-send-email-gene@czarc.net> <1358715858-4469-13-git-send-email-gene@czarc.net>
In-Reply-To: <1358715858-4469-13-git-send-email-gene@czarc.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: linux-btrfs-owner@vger.kernel.org
List-ID: <linux-btrfs.vger.kernel.org>

At the request of the patch's author, this should be dropped as it has 
been addressed by a patch to the kernel.

On 01/20/2013 04:04 PM, Gene Czarcinski wrote:
> From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
>
> In kernel, qgroupid 0 is a special number when we run the quota group limit command.
>
> So, we should not be able to create a quota group whose id is 0, otherwise the kernel
> can't deal with it. Fix it.
>
> Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
> Signed-off-by: Gene Czarcinski <gene@czarc.net>
> ---
>   cmds-qgroup.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/cmds-qgroup.c b/cmds-qgroup.c
> index 70019d0..dfff1b9 100644
> --- a/cmds-qgroup.c
> +++ b/cmds-qgroup.c
> @@ -86,6 +86,10 @@ static int qgroup_create(int create, int argc, char **argv)
>   	args.create = create;
>   	args.qgroupid = parse_qgroupid(argv[1]);
>   
> +	if (!args.qgroupid) {
> +		fprintf(stderr, "ERROR: qgroup 0 is not supported\n");
> +		return 30;
> +	}
>   	fd = open_file_or_dir(path);
>   	if (fd < 0) {
>   		fprintf(stderr, "ERROR: can't access '%s'\n", path);