From: Gene Czarcinski <gene@czarc.net>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 06/13] btrfs-show-super.c
Date: Tue, 22 Jan 2013 13:00:56 -0500 [thread overview]
Message-ID: <50FED3D8.1080208@czarc.net> (raw)
In-Reply-To: <20130121164628.GK19967@twin.jikos.cz>
On 01/21/2013 11:46 AM, David Sterba wrote:
> On Sun, Jan 20, 2013 at 04:04:11PM -0500, Gene Czarcinski wrote:
>> remove extra blank line at EOF
> The patch contents and description do not match.
First of all, this patch should have been 2 separate patches. Too late
to fix that.
The patch which created btrfs-show-super.c had an extra line at the end
and I got annoyed at git-am complaining about it. This first patch
fixes that. This should have been a separate commit.
The other patch (which should have been its own commit) addresses this
problem:
http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg19264.html
I could not see that it did any harm and it helped on at least one
system type
I am not sure how it happened that I combined them. If you want, I will
resubmit them the way it should be ... two separate patches with two
separate commits.
Gene
>
>> --- a/man/Makefile
>> +++ b/man/Makefile
>> @@ -1,4 +1,4 @@
>> -GZIP=gzip
>> +GZIPCMD=gzip
> I'm not sure if this change is needed, does it stick to some well-known
> or established style in makefiles?
>
> david
>
>
next prev parent reply other threads:[~2013-01-22 18:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 21:04 [PATCH 00/13] Btrfs-progs: more patches for integration Gene Czarcinski
2013-01-20 21:04 ` [PATCH 01/13] btrfs-progs: btrfs-image.c: Added NULL pointer check Gene Czarcinski
2013-01-21 15:56 ` David Sterba
2013-01-22 17:34 ` Gene Czarcinski
2013-01-23 16:35 ` David Sterba
2013-01-23 18:16 ` Gene Czarcinski
2013-01-20 21:04 ` [PATCH 02/13] Btrfs-progs: fix resolving of loop devices Gene Czarcinski
2013-01-21 16:14 ` David Sterba
2013-01-22 17:50 ` David Sterba
2013-01-20 21:04 ` [PATCH 03/13] Btrfs-progs: correct btrfs receive usage string Gene Czarcinski
2013-01-20 21:04 ` [PATCH 04/13] Btrfs-progs: Fix a segmentation fault in btrfstune when <device> is invalid Gene Czarcinski
2013-01-20 21:04 ` [PATCH 05/13] Add btrfs-show-super Gene Czarcinski
2013-01-21 18:04 ` David Sterba
2013-01-21 19:54 ` Goffredo Baroncelli
2013-01-21 22:22 ` Stefan Behrens
2013-01-22 14:46 ` David Sterba
2013-01-20 21:04 ` [PATCH 06/13] btrfs-show-super.c Gene Czarcinski
2013-01-21 16:46 ` David Sterba
2013-01-22 18:00 ` Gene Czarcinski [this message]
2013-01-23 17:38 ` David Sterba
2013-01-22 20:51 ` [PATCH] Fix Makefile for gzip Gene Czarcinski
2013-01-22 20:51 ` [PATCH] fix btrfs-progs build Gene Czarcinski
2013-01-23 17:42 ` David Sterba
2013-01-20 21:04 ` [PATCH 07/13] Btrfs-progs: correcting misnamed parameter options for btrfs send Gene Czarcinski
2013-01-20 21:49 ` Gene Czarcinski
2013-01-20 23:59 ` [PATCH] " Gene Czarcinski
2013-01-20 21:04 ` [PATCH 08/13] Btrfs-progs: bugfix for subvolume parent determination in " Gene Czarcinski
2013-01-20 21:04 ` [PATCH 09/13] Btrfs-progs: fix arg parsing for btrfs qgroup limit commands Gene Czarcinski
2013-01-20 21:04 ` [PATCH 10/13] Btrfs-progs: clean up reduplicate parse_qgroupid() and replace atoi with strtoull Gene Czarcinski
2013-01-20 21:04 ` [PATCH 11/13] Btrfs-progs: check the relation of two group by real level numbers Gene Czarcinski
2013-01-20 21:04 ` [PATCH 12/13] Btrfs-progs: disable qgroupid 0 for quota_tree Gene Czarcinski
2013-01-21 14:11 ` Gene Czarcinski
2013-01-20 21:04 ` [PATCH 13/13] trivial patch for btrfs-progs Gene Czarcinski
2013-01-21 17:40 ` David Sterba
2013-01-22 18:59 ` Gene Czarcinski
2013-01-21 18:40 ` [PATCH 00/13] Btrfs-progs: more patches for integration (integration-20130121) David Sterba
[not found] ` <CAMO4zugaABrbTJB75Yyi_UravfSX81YyqJtmc3yGALrby7+RTQ@mail.gmail.com>
2013-01-22 17:03 ` Fwd: " praneeth u
2013-01-22 18:09 ` Gene Czarcinski
2013-01-22 20:14 ` Gene Czarcinski
2013-01-24 18:13 ` David Sterba
2013-01-24 21:07 ` Gene Czarcinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FED3D8.1080208@czarc.net \
--to=gene@czarc.net \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).