From: Jan Schmidt <list.btrfs@jan-o-sch.net>
To: miaox@cn.fujitsu.com
Cc: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org,
jmwdev38@gmail.com, jbacik@fusionio.com, sensille@gmx.net
Subject: Re: [PATCH] Btrfs: fix ENOSPC in qgroups (metadata)
Date: Mon, 28 Jan 2013 13:50:56 +0100 [thread overview]
Message-ID: <51067430.1070009@jan-o-sch.net> (raw)
In-Reply-To: <510672B2.7000601@cn.fujitsu.com>
Hi Miao,
On 28.01.2013 13:44, Miao Xie wrote:
> On mon, 28 Jan 2013 13:03:46 +0100, Jan Schmidt wrote:
>> When start_transaction() returns ENOSPC after btrfs_qgroup_reserve(), we
>> must call btrfs_qgroup_free() to avoid the qgroup counters increasing when
>> there's actually no data being written.
>>
>> Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
>> ---
>> Josef: It looks like these places (except the first) are candidates for
>> btrfs_block_rsv_release, please check.
>
> I didn't note that you have made a patch for the qgroup reservation problem, so I sent
> my fix patch.
>
> But start_transaction() has reservation problems not only for qgroup, but also for
> the free space, your patch didn't fix the free space reservation problem.
I see, we better take your patch then. Although my commit message was
way more descriptive ;-)
Josef: You've been saved.
Thanks,
-Jan
prev parent reply other threads:[~2013-01-28 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 12:03 [PATCH] Btrfs: fix ENOSPC in qgroups (metadata) Jan Schmidt
2013-01-28 12:44 ` Miao Xie
2013-01-28 12:50 ` Jan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51067430.1070009@jan-o-sch.net \
--to=list.btrfs@jan-o-sch.net \
--cc=chris.mason@fusionio.com \
--cc=jbacik@fusionio.com \
--cc=jmwdev38@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).