From: Eric Sandeen <sandeen@redhat.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fix parallel build
Date: Thu, 31 Jan 2013 09:32:15 -0600 [thread overview]
Message-ID: <510A8E7F.2080407@redhat.com> (raw)
In-Reply-To: <1359636652-20586-1-git-send-email-dsterba@suse.cz>
On 1/31/13 6:50 AM, David Sterba wrote:
> Parallel build may fail due to late creation of version.h, fix the rule name
> that does not match the filename.
>
> Signed-off-by: David Sterba <dsterba@suse.cz>
Look good, thanks. surprised I didn't run into this.
Reviewed-by: Eri Sandeen <sandeen@redhat.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 6df402c..bef1e13 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -52,9 +52,9 @@ endif
> $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
>
>
> -all: version $(progs) manpages
> +all: version.h $(progs) manpages
>
> -version:
> +version.h:
> $(Q)bash version.sh
>
> btrfs: $(objects) btrfs.o help.o $(cmds_objects)
>
next prev parent reply other threads:[~2013-01-31 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 12:50 [PATCH] btrfs-progs: fix parallel build David Sterba
2013-01-31 15:32 ` Eric Sandeen [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-03 1:52 rongqing.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A8E7F.2080407@redhat.com \
--to=sandeen@redhat.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).