linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Chris Mason <chris.mason@fusionio.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table
Date: Thu, 14 Feb 2013 15:20:57 -0600	[thread overview]
Message-ID: <511D5539.1010708@redhat.com> (raw)
In-Reply-To: <20130214202324.GD3919@shiny.masoncoding.com>

On 2/14/13 2:23 PM, Chris Mason wrote:
> On Thu, Feb 14, 2013 at 11:30:03AM -0700, Eric Sandeen wrote:
>> The core of this is shamelessly stolen from xfsprogs.
>>
>> Use blkid to detect an existing filesystem or partition
>> table on any of the target devices.  If something is found,
>> require the '-f' option to overwrite it, hopefully avoiding
>> disaster due to mistyped devicenames, etc.
> 
> So, this has always been the one thing I didn't want to steal from XFS.
> I don't have a good reason though, and it seems like it is time to bring
> this in.

If you really don't want to, I'm not wedded to it.  It just came up on the 
other thread, and it's easy enough to throw it out there for discussion.

I don't like a million "are you really sure?!"'s from tools, but now 
and then it's nice to have a little barrier to screwup.

So, do as you like with it, I won't be offended if you don't want it.

> Just to get back at you though, I'll turn on an incandescent light bulb
> every time I have to use -f.

NOOOO that seals the deal.  I retract the patch.   ;)

-Eric

> -chris
> 


  reply	other threads:[~2013-02-14 21:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 18:30 [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table Eric Sandeen
2013-02-14 20:23 ` Chris Mason
2013-02-14 21:20   ` Eric Sandeen [this message]
2013-02-20 15:37 ` Stefan Behrens
2013-02-25 23:39   ` Tsutomu Itoh
2013-02-26  0:07     ` Eric Sandeen
2013-02-26  3:55       ` Tsutomu Itoh
2013-02-26  4:06         ` Eric Sandeen
2013-02-26  4:25           ` Tsutomu Itoh
2013-02-26  7:05             ` Dave Chinner
2013-02-26  8:53               ` Tsutomu Itoh
2013-02-28 16:30               ` mpbtr
2013-02-26 10:37         ` Martin Steigerwald
2013-02-26 19:12           ` Goffredo Baroncelli
2013-02-26 21:16             ` Martin Steigerwald
2013-02-26 12:43     ` David Sterba
2013-02-26 20:23   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511D5539.1010708@redhat.com \
    --to=sandeen@redhat.com \
    --cc=chris.mason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).