From: Goffredo Baroncelli <kreijack@tiscalinet.it>
To: Zach Brown <zab@zabbo.net>
Cc: kreijack@inwind.it, linux-btrfs@vger.kernel.org,
"Hugo Mills" <hugo@carfax.org.uk>,
"Michael Kjörling" <michael@kjorling.se>,
"Martin Steigerwald" <Martin@lichtvoll.de>,
cwillu <cwillu@cwillu.com>,
"Chris Murphy" <lists@colorremedies.com>,
"David Sterba" <dsterba@suse.cz>
Subject: Re: [PATCH 1/8] Add some helpers to manage the strings allocation/deallocation.
Date: Tue, 19 Feb 2013 22:28:36 +0100 [thread overview]
Message-ID: <5123EE84.8000502@tiscalinet.it> (raw)
In-Reply-To: <20130219175948.GQ22221@lenny.home.zabbo.net>
On 02/19/2013 06:59 PM, Zach Brown wrote:
>> Sorry but this is very dangerous and it leads to very subtle bug: what
>> happens if someone wrote:
>
> "very dangerous"? I disagree.
>
> If you're worried about the value and units getting out of sync then you
> offer some helper macros:
No my complaint was related to another thing; but I was wrong. Anyway
your suggestion is not so easy applicable, and (IMHO) I don't see any
difficulty to remember to call string_list_free() only at the end of the
code.
>
>> printf("%d%s - %d%s\n", scale(123), unit_string(123),
>> scale(123), unit_string(456) );
>
> #define pty_fmt "%llu%s"
> #define pty_arg(v) scale(v), unit_string(v)
>
> printf(pty_fmt, pty_arg(v));
>
> The kernel used to print ipv4 addresses like this before it grew its own
> %pI4 format specifier.
>
> - z
>
--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2013-02-19 21:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 21:04 [PATCH][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 1/8] Add some helpers to manage the strings allocation/deallocation Goffredo Baroncelli
2013-02-18 23:08 ` Zach Brown
2013-02-19 7:07 ` Goffredo Baroncelli
2013-02-19 17:21 ` Zach Brown
2013-02-19 17:44 ` Goffredo Baroncelli
2013-02-19 17:59 ` Zach Brown
2013-02-19 21:28 ` Goffredo Baroncelli [this message]
2013-02-19 21:40 ` Zach Brown
2013-02-18 21:04 ` [PATCH 2/8] Enhance the command btrfs filesystem df Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 3/8] Create the man page entry for the command btrfs fi df Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 4/8] Add helpers functions to handle the printing of data in tabular format Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 5/8] Add command btrfs filesystem disk-usage Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 6/8] Create entry in man page for " Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 7/8] Add btrfs device disk-usage command Goffredo Baroncelli
2013-02-18 21:04 ` [PATCH 8/8] Create a new entry in btrfs man page for btrfs device disk-usage Goffredo Baroncelli
-- strict thread matches above, loose matches on Subject: below --
2013-02-23 13:46 [PATCH V2][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support Goffredo Baroncelli
2013-02-23 13:46 ` [PATCH 1/8] Add some helpers to manage the strings allocation/deallocation Goffredo Baroncelli
2013-02-25 2:20 ` Eric Sandeen
2013-02-25 19:59 ` Goffredo Baroncelli
2013-02-25 20:19 ` Zach Brown
2013-02-25 21:00 ` Goffredo Baroncelli
2013-03-10 12:17 [PATCH V3][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support Goffredo Baroncelli
2013-03-10 12:17 ` [PATCH 1/8] Add some helpers to manage the strings allocation/deallocation Goffredo Baroncelli
2013-03-10 14:34 ` Wang Shilong
2013-03-10 14:51 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123EE84.8000502@tiscalinet.it \
--to=kreijack@tiscalinet.it \
--cc=Martin@lichtvoll.de \
--cc=cwillu@cwillu.com \
--cc=dsterba@suse.cz \
--cc=hugo@carfax.org.uk \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=lists@colorremedies.com \
--cc=michael@kjorling.se \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).