Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Audrius Butkevicius <audrius.butkevicius@elastichosts.com>
To: Hugo Mills <hugo@carfax.org.uk>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: add '-b' option to filesystem df and show
Date: Wed, 20 Feb 2013 13:05:57 +0000	[thread overview]
Message-ID: <5124CA35.2080009@elastichosts.com> (raw)
In-Reply-To: <20130201103031.GQ16285@carfax.org.uk>

On 01/02/2013 10:30, Hugo Mills wrote:
> On Fri, Feb 01, 2013 at 09:59:49AM +0000, Audrius Butkevicius wrote:
>> Add '-b' and '--bytes' options to btrfs filesystem df and show, for easier
>> integration with scripts. This causes all sizes to be displayed in decimal
>> bytes instead of pretty-printed with human-readable suffices KB, MB, etc.
>     Please, not this way.
>

Hi Hugo,

Just wanted to check which approach you'd prefer to see me adopt:

1. Providing an option which is handled near the entry point (prior 
going to commands), which would toggle a global flag to indicate the 
format.

2. An option in every function which uses pretty sizes. (Though -B seems 
to be used by scrub, -b is used by calc-size and mkfs utils, -u is used 
by subvolume list and so on, meaning the option might have to be 
different for different commands)

3. An environment variable BTRFS_UNITS, which when set to b[ytes], 
changes the behaviour of pretty printing. Avoids having to touch the 
multiple sets of ad-hoc option parsing code, but is perhaps a slightly 
non-standard interface.

Thanks,
Audrius.

  reply	other threads:[~2013-02-20 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01  9:59 [PATCH] btrfs-progs: add '-b' option to filesystem df and show Audrius Butkevicius
2013-02-01 10:30 ` Hugo Mills
2013-02-20 13:05   ` Audrius Butkevicius [this message]
2013-02-20 14:15     ` Mike Fleetwood
2013-02-20 14:54       ` Hugo Mills
2013-02-20 18:17         ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5124CA35.2080009@elastichosts.com \
    --to=audrius.butkevicius@elastichosts.com \
    --cc=hugo@carfax.org.uk \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox