From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table
Date: Wed, 20 Feb 2013 16:37:15 +0100 [thread overview]
Message-ID: <5124EDAB.5020003@giantdisaster.de> (raw)
In-Reply-To: <511D2D2B.8040804@redhat.com>
On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote:
> The core of this is shamelessly stolen from xfsprogs.
>
> Use blkid to detect an existing filesystem or partition
> table on any of the target devices. If something is found,
> require the '-f' option to overwrite it, hopefully avoiding
> disaster due to mistyped devicenames, etc.
>
> # mkfs.btrfs /dev/sda1
>
> WARNING! - Btrfs v0.20-rc1-59-gd00279c-dirty IS EXPERIMENTAL
> WARNING! - see http://btrfs.wiki.kernel.org before using
>
> /dev/sda1 appears to contain an existing filesystem (xfs).
> Use the -f option to force overwrite.
> #
>
> This does introduce a requirement on libblkid.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
This means that it is now required to change all occurrences of
"mkfs.btrfs" to "mkfs.btrfs -f" everywhere. Can't we first establish a
time period of 100 years where the -f option is tolerated and ignored,
and then in 2113 we require that the users add the -f option?
(Just had to do this string replacement everywhere, and had to add -f to
xfstest's _scratch_mkfs in common.rc as well). Sigh.
next prev parent reply other threads:[~2013-02-20 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 18:30 [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table Eric Sandeen
2013-02-14 20:23 ` Chris Mason
2013-02-14 21:20 ` Eric Sandeen
2013-02-20 15:37 ` Stefan Behrens [this message]
2013-02-25 23:39 ` Tsutomu Itoh
2013-02-26 0:07 ` Eric Sandeen
2013-02-26 3:55 ` Tsutomu Itoh
2013-02-26 4:06 ` Eric Sandeen
2013-02-26 4:25 ` Tsutomu Itoh
2013-02-26 7:05 ` Dave Chinner
2013-02-26 8:53 ` Tsutomu Itoh
2013-02-28 16:30 ` mpbtr
2013-02-26 10:37 ` Martin Steigerwald
2013-02-26 19:12 ` Goffredo Baroncelli
2013-02-26 21:16 ` Martin Steigerwald
2013-02-26 12:43 ` David Sterba
2013-02-26 20:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5124EDAB.5020003@giantdisaster.de \
--to=sbehrens@giantdisaster.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).