From: Blair Zajac <blair@orcaware.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix overhead check for qgroupid in the kernel
Date: Mon, 25 Feb 2013 09:38:50 -0800 [thread overview]
Message-ID: <512BA1AA.4000309@orcaware.com> (raw)
In-Reply-To: <1361802632-2491-1-git-send-email-wangshilong1991@gmail.com>
On 02/25/2013 06:30 AM, Wang Shilong wrote:
> From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
>
> As we implement the strict hierarchy quota in the userspace,
> it is sufficient to check this ruler in the userspace.remove
> the special check for qgroup 0.
I haven't done any kernel coding so I'm curious, but is this a safe
change? When I code, I always have the authoritative code do a check,
e.g. in web programing, the browser can do data validation but you
always have the web server check incoming data also, so it doesn't hurt
to have it in the kernel itself.
The other thing is that it is possible for people and distributions to
upgrade the kernel without upgrading the btrfs tools, so there could be
a window when there is no check on somebody's system.
Regards,
Blair
prev parent reply other threads:[~2013-02-25 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 14:30 [PATCH] Btrfs: fix overhead check for qgroupid in the kernel Wang Shilong
2013-02-25 17:38 ` Blair Zajac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512BA1AA.4000309@orcaware.com \
--to=blair@orcaware.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).