From: Eric Sandeen <sandeen@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Wang Sheng-Hui <shhuiw@gmail.com>, xfstests <xfs@oss.sgi.com>,
linux-btrfs@vger.kernel.org, list.btrfs@jan-o-sch.net
Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
Date: Wed, 27 Feb 2013 17:11:01 -0600 [thread overview]
Message-ID: <512E9285.30005@redhat.com> (raw)
In-Reply-To: <20130227230443.GB5551@dastard>
On 2/27/13 5:04 PM, Dave Chinner wrote:
> On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote:
>> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
>> -x option of filefrag, and will fail with
>> 'FIBMAP: Invalid argument'
>> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>> 'FIEMAP failed with unsupported flags 2'
>> Remove the '-x' option.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
>
> I can see that this changes what gets dumped into the $seq.full
> file, but it seems to me that also changes the extent list returned
> to the checking functions. So either the test previously worked and
> now it fails with this change, or the test never worked and now it
> does, or perhaps something else?
Agreed - I wondered as well.
> IOWs, I can't tell why you want to change this from the patch
> description, hence I don't know if the original behaviour was
> intentional or not. Can you say describe what the overall effect of
> the change is in the commit description?
It looks like -x is only recently rejected:
commit 05dadc09f52ad5a631da1aa8767c5b80e121f0c4
Author: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Date: Thu Nov 29 05:08:26 2012 +0000
Btrfs: add fiemap's flag check
+#define BTRFS_FIEMAP_FLAGS (FIEMAP_FLAG_SYNC)
+ ret = fiemap_check_flags(fieinfo, BTRFS_FIEMAP_FLAGS);
-Eric
> Cheers,
>
> Dave.
>
next prev parent reply other threads:[~2013-02-27 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 7:15 [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' Wang Sheng-Hui
2013-02-27 23:04 ` Dave Chinner
2013-02-27 23:11 ` Eric Sandeen [this message]
2013-02-28 0:02 ` Wang Sheng-Hui
2013-02-28 0:25 ` Dave Chinner
2013-02-28 2:05 ` Wang Sheng-Hui
2013-03-05 18:43 ` Rich Johnston
2013-05-26 9:35 ` Zhi Yong Wu
2013-05-26 17:35 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E9285.30005@redhat.com \
--to=sandeen@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=shhuiw@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).