* [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
@ 2013-02-27 7:15 Wang Sheng-Hui
2013-02-27 23:04 ` Dave Chinner
2013-03-05 18:43 ` Rich Johnston
0 siblings, 2 replies; 9+ messages in thread
From: Wang Sheng-Hui @ 2013-02-27 7:15 UTC (permalink / raw)
To: xfstests, linux-btrfs, list.btrfs
Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
-x option of filefrag, and will fail with
'FIBMAP: Invalid argument'
for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
'FIEMAP failed with unsupported flags 2'
Remove the '-x' option.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
276 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/276 b/276
index 082f943..f2b17c9 100755
--- a/276
+++ b/276
@@ -75,7 +75,7 @@ _filter_extents()
_check_file_extents()
{
- cmd="filefrag -vx $1"
+ cmd="filefrag -v $1"
echo "# $cmd" >> $seq.full
out=`$cmd | _filter_extents`
if [ -z "$out" ]; then
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-02-27 7:15 [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' Wang Sheng-Hui @ 2013-02-27 23:04 ` Dave Chinner 2013-02-27 23:11 ` Eric Sandeen 2013-02-28 0:02 ` Wang Sheng-Hui 2013-03-05 18:43 ` Rich Johnston 1 sibling, 2 replies; 9+ messages in thread From: Dave Chinner @ 2013-02-27 23:04 UTC (permalink / raw) To: Wang Sheng-Hui; +Cc: xfstests, linux-btrfs, list.btrfs On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: > Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by > -x option of filefrag, and will fail with > 'FIBMAP: Invalid argument' > for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with > 'FIEMAP failed with unsupported flags 2' > Remove the '-x' option. > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> I can see that this changes what gets dumped into the $seq.full file, but it seems to me that also changes the extent list returned to the checking functions. So either the test previously worked and now it fails with this change, or the test never worked and now it does, or perhaps something else? IOWs, I can't tell why you want to change this from the patch description, hence I don't know if the original behaviour was intentional or not. Can you say describe what the overall effect of the change is in the commit description? Cheers, Dave. -- Dave Chinner david@fromorbit.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-02-27 23:04 ` Dave Chinner @ 2013-02-27 23:11 ` Eric Sandeen 2013-02-28 0:02 ` Wang Sheng-Hui 1 sibling, 0 replies; 9+ messages in thread From: Eric Sandeen @ 2013-02-27 23:11 UTC (permalink / raw) To: Dave Chinner; +Cc: Wang Sheng-Hui, xfstests, linux-btrfs, list.btrfs On 2/27/13 5:04 PM, Dave Chinner wrote: > On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: >> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by >> -x option of filefrag, and will fail with >> 'FIBMAP: Invalid argument' >> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with >> 'FIEMAP failed with unsupported flags 2' >> Remove the '-x' option. >> >> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > > I can see that this changes what gets dumped into the $seq.full > file, but it seems to me that also changes the extent list returned > to the checking functions. So either the test previously worked and > now it fails with this change, or the test never worked and now it > does, or perhaps something else? Agreed - I wondered as well. > IOWs, I can't tell why you want to change this from the patch > description, hence I don't know if the original behaviour was > intentional or not. Can you say describe what the overall effect of > the change is in the commit description? It looks like -x is only recently rejected: commit 05dadc09f52ad5a631da1aa8767c5b80e121f0c4 Author: Tsutomu Itoh <t-itoh@jp.fujitsu.com> Date: Thu Nov 29 05:08:26 2012 +0000 Btrfs: add fiemap's flag check +#define BTRFS_FIEMAP_FLAGS (FIEMAP_FLAG_SYNC) + ret = fiemap_check_flags(fieinfo, BTRFS_FIEMAP_FLAGS); -Eric > Cheers, > > Dave. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-02-27 23:04 ` Dave Chinner 2013-02-27 23:11 ` Eric Sandeen @ 2013-02-28 0:02 ` Wang Sheng-Hui 2013-02-28 0:25 ` Dave Chinner 1 sibling, 1 reply; 9+ messages in thread From: Wang Sheng-Hui @ 2013-02-28 0:02 UTC (permalink / raw) To: Dave Chinner; +Cc: xfstests, linux-btrfs, list.btrfs On 2013年02月28日 07:04, Dave Chinner wrote: > On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: >> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by >> -x option of filefrag, and will fail with >> 'FIBMAP: Invalid argument' >> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with >> 'FIEMAP failed with unsupported flags 2' >> Remove the '-x' option. >> >> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > > I can see that this changes what gets dumped into the $seq.full > file, but it seems to me that also changes the extent list returned > to the checking functions. So either the test previously worked and > now it fails with this change, or the test never worked and now it > does, or perhaps something else? > > IOWs, I can't tell why you want to change this from the patch > description, hence I don't know if the original behaviour was > intentional or not. Can you say describe what the overall effect of > the change is in the commit description? Hi Dave, I run xfstests for btrfs against SLES11SP2, not upstream kernel. In the seq.full, I can get the messages 'FIEMAP failed with unsupported flags 2' Then I found that the test will run 'filefrag -vx' on btrfs, and '-v' will run FIEMAP_FLAG_XATTR, which is not supported by btrfs yet, at least in 3.8 kernel. Without the patch, I failed the testcase and got: ============================================= 276 8s ... - output mismatch (see 276.out.bad) --- 276.out 2013-02-25 19:08:58.000000000 -0600 +++ 276.out.bad 2013-02-27 17:59:48.000000000 -0600 @@ -1,4 +1,867 @@ QA output created by 276 *** test backref walking +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument ... (Run 'diff -u 276.out 276.out.bad' to see the entire diff) Ran: 276 Failures: 276 Failed 1 of 1 tests In the 276.full, I got something like: ============================================= # filefrag -vx /mnt/scratch/snap1/p0/d4/d21/d4a/f58 Filesystem type is: 9123683e File size of /mnt/scratch/snap1/p0/d4/d21/d4a/f58 is 2125615 (33 blocks, blocksize 65536) FIEMAP failed with unsupported flags 2 With the patch, I can pass the testcase: ============================================= 276 8s ... 7s Ran: 276 Passed all 1 tests > > Cheers, > > Dave. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-02-28 0:02 ` Wang Sheng-Hui @ 2013-02-28 0:25 ` Dave Chinner 2013-02-28 2:05 ` Wang Sheng-Hui 0 siblings, 1 reply; 9+ messages in thread From: Dave Chinner @ 2013-02-28 0:25 UTC (permalink / raw) To: Wang Sheng-Hui; +Cc: xfstests, linux-btrfs, list.btrfs On Thu, Feb 28, 2013 at 08:02:52AM +0800, Wang Sheng-Hui wrote: > On 2013年02月28日 07:04, Dave Chinner wrote: > >On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: > >>Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by > >>-x option of filefrag, and will fail with > >> 'FIBMAP: Invalid argument' > >>for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with > >> 'FIEMAP failed with unsupported flags 2' > >>Remove the '-x' option. > >> > >>Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > > > >I can see that this changes what gets dumped into the $seq.full > >file, but it seems to me that also changes the extent list returned > >to the checking functions. So either the test previously worked and > >now it fails with this change, or the test never worked and now it > >does, or perhaps something else? > > > >IOWs, I can't tell why you want to change this from the patch > >description, hence I don't know if the original behaviour was > >intentional or not. Can you say describe what the overall effect of > >the change is in the commit description? > > Hi Dave, > > I run xfstests for btrfs against SLES11SP2, not upstream kernel. > In the seq.full, I can get the messages > 'FIEMAP failed with unsupported flags 2' > > Then I found that the test will run 'filefrag -vx' on btrfs, and > '-v' will run FIEMAP_FLAG_XATTR, which is not supported by btrfs > yet, at least in 3.8 kernel. Sure, I understand that. I'm not asking about how it fails - that much is obvious. What I am asking is: - did it ever work? - if it did, why did it start failing? - how long has it been broken for? > With the patch, I can pass the testcase: > ============================================= > 276 8s ... 7s > Ran: 276 > Passed all 1 tests Great, but why did it break in the first place? That's the information that needs to be in the commit message. Indeed, Eric has pointed out to us *exactly* the information that shoul dbe in the commit message. i.e. a description along the lines of: "Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity checks to the fiemap flags and hence invalid flags are now being rejected. Test 276 passes an invalid fiemap flag to btrfs, and so that test fails since this commit was added." That tells us exactly why the test failed, why the change is necessary, and how long the test has been broken for. Seen another way, it makes me wonder how often anyone runs xfstests on a btrfs dev tree or regression tests their own changes. Cheers, Dave. -- Dave Chinner david@fromorbit.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-02-28 0:25 ` Dave Chinner @ 2013-02-28 2:05 ` Wang Sheng-Hui 0 siblings, 0 replies; 9+ messages in thread From: Wang Sheng-Hui @ 2013-02-28 2:05 UTC (permalink / raw) To: Dave Chinner; +Cc: xfstests, linux-btrfs, list.btrfs, sandeen On 2013年02月28日 08:25, Dave Chinner wrote: > On Thu, Feb 28, 2013 at 08:02:52AM +0800, Wang Sheng-Hui wrote: >> On 2013年02月28日 07:04, Dave Chinner wrote: >>> On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: >>>> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by >>>> -x option of filefrag, and will fail with >>>> 'FIBMAP: Invalid argument' >>>> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with >>>> 'FIEMAP failed with unsupported flags 2' >>>> Remove the '-x' option. >>>> >>>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> >>> >>> I can see that this changes what gets dumped into the $seq.full >>> file, but it seems to me that also changes the extent list returned >>> to the checking functions. So either the test previously worked and >>> now it fails with this change, or the test never worked and now it >>> does, or perhaps something else? >>> >>> IOWs, I can't tell why you want to change this from the patch >>> description, hence I don't know if the original behaviour was >>> intentional or not. Can you say describe what the overall effect of >>> the change is in the commit description? >> >> Hi Dave, >> >> I run xfstests for btrfs against SLES11SP2, not upstream kernel. >> In the seq.full, I can get the messages >> 'FIEMAP failed with unsupported flags 2' >> >> Then I found that the test will run 'filefrag -vx' on btrfs, and >> '-v' will run FIEMAP_FLAG_XATTR, which is not supported by btrfs >> yet, at least in 3.8 kernel. > > Sure, I understand that. I'm not asking about how it fails - that > much is obvious. What I am asking is: > > - did it ever work? > - if it did, why did it start failing? > - how long has it been broken for? > >> With the patch, I can pass the testcase: >> ============================================= >> 276 8s ... 7s >> Ran: 276 >> Passed all 1 tests > > Great, but why did it break in the first place? That's the > information that needs to be in the commit message. Indeed, Eric has > pointed out to us *exactly* the information that shoul dbe in the > commit message. i.e. a description along the lines of: > > "Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity > checks to the fiemap flags and hence invalid flags are now being > rejected. Test 276 passes an invalid fiemap flag to btrfs, and so > that test fails since this commit was added." > > That tells us exactly why the test failed, why the change is > necessary, and how long the test has been broken for. Seen another > way, it makes me wonder how often anyone runs xfstests on a btrfs > dev tree or regression tests their own changes. > > Cheers, > > Dave. > Modify the commit message. ---------------------------------------------------------------- Per Eric, Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity checks to the fiemap flags and hence invalid flags are now being rejected. Test 276 passes an invalid fiemap flag to btrfs, and so that test fails since this commit was added. Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by -x option of filefrag, and will fail with 'FIBMAP: Invalid argument' for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with 'FIEMAP failed with unsupported flags 2' Remove the '-x' option. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- 276 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/276 b/276 index 082f943..f2b17c9 100755 --- a/276 +++ b/276 @@ -75,7 +75,7 @@ _filter_extents() _check_file_extents() { - cmd="filefrag -vx $1" + cmd="filefrag -v $1" echo "# $cmd" >> $seq.full out=`$cmd | _filter_extents` if [ -z "$out" ]; then -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-02-27 7:15 [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' Wang Sheng-Hui 2013-02-27 23:04 ` Dave Chinner @ 2013-03-05 18:43 ` Rich Johnston 2013-05-26 9:35 ` Zhi Yong Wu 1 sibling, 1 reply; 9+ messages in thread From: Rich Johnston @ 2013-03-05 18:43 UTC (permalink / raw) To: Wang Sheng-Hui; +Cc: xfstests, linux-btrfs, list.btrfs This patch has been committed. --Rich commit eba3a5206cd7f8df73d6e6dbf2bb0afca677fca8 Author: Wang Sheng-Hui <shhuiw@gmail.com> Date: Thu Feb 28 02:05:56 2013 +0000 xfstests 276: fix error 'FIBMAP: Invalid argument' Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity checks to the fiemap flags and hence invalid flags are now being rejected. Test 276 passes an invalid fiemap flag to btrfs, and so that test fails since this commit was added. Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by -x option of filefrag, and will fail with 'FIBMAP: Invalid argument' for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with 'FIEMAP failed with unsupported flags 2' Remove the '-x' option. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-03-05 18:43 ` Rich Johnston @ 2013-05-26 9:35 ` Zhi Yong Wu 2013-05-26 17:35 ` Eric Sandeen 0 siblings, 1 reply; 9+ messages in thread From: Zhi Yong Wu @ 2013-05-26 9:35 UTC (permalink / raw) To: Rich Johnston; +Cc: Wang Sheng-Hui, list.btrfs, linux-btrfs, xfstests HI, This issue still exists when xfstests is run on debian although xfstests has contained this patch. root@debian-i386:/home/zwu/xfstests# git describe linux-v3.8-122-gdc75401 root@debian-i386:/home/zwu/xfstests# uname -a Linux debian-i386 3.10.0-rc2+ #3 SMP Sun May 26 14:04:13 CST 2013 x86_64 GNU/Linux root@debian-i386:/home/zwu/xfstests# - output mismatch (see /home/zwu/xfstests/results/btrfs/276.out.bad) --- tests/btrfs/276.out 2013-05-25 15:09:01.000000000 +0000 +++ /home/zwu/xfstests/results/btrfs/276.out.bad 2013-05-26 09:31:49.962876905 +0000 @@ -1,3 +1,32393 @@ QA output created by 276 *** test backref walking +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument ... (Run 'diff -u tests/btrfs/276.out /home/zwu/xfstests/results/btrfs/276.out.bad' to see the entire diff) [ 3877.215268] device fsid 8367602a-14fa-49eb-aff0-44da1faa3b45 devid 1 transid 239 /dev/vdb [ 3877.218417] btrfs: disk space caching is enabled Ran: btrfs/276 Failures: btrfs/276 Failed 1 of 1 tests On Wed, Mar 6, 2013 at 2:43 AM, Rich Johnston <rjohnston@sgi.com> wrote: > This patch has been committed. > > --Rich > > commit eba3a5206cd7f8df73d6e6dbf2bb0afca677fca8 > Author: Wang Sheng-Hui <shhuiw@gmail.com> > Date: Thu Feb 28 02:05:56 2013 +0000 > > xfstests 276: fix error 'FIBMAP: Invalid argument' > > > Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity > checks to the fiemap flags and hence invalid flags are now being > rejected. Test 276 passes an invalid fiemap flag to btrfs, and so > that test fails since this commit was added. > > Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by -x option > of filefrag, and will fail with > 'FIBMAP: Invalid argument' > for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with > 'FIEMAP failed with unsupported flags 2' > Remove the '-x' option. > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs -- Regards, Zhi Yong Wu ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' 2013-05-26 9:35 ` Zhi Yong Wu @ 2013-05-26 17:35 ` Eric Sandeen 0 siblings, 0 replies; 9+ messages in thread From: Eric Sandeen @ 2013-05-26 17:35 UTC (permalink / raw) To: Zhi Yong Wu Cc: Rich Johnston, xfstests, linux-btrfs, list.btrfs, Wang Sheng-Hui On 5/26/13 4:35 AM, Zhi Yong Wu wrote: > HI, > > This issue still exists when xfstests is run on debian although > xfstests has contained this patch. "this issue" must be different, then; same error ("Invalid argument") but it can no longer be due to the -x option to filefrag. There must be some other root cause. Needs investigation on the btrfs side. IOWs, this looks like it could be a regression in btrfs? -Eric > root@debian-i386:/home/zwu/xfstests# git describe > linux-v3.8-122-gdc75401 > root@debian-i386:/home/zwu/xfstests# uname -a > Linux debian-i386 3.10.0-rc2+ #3 SMP Sun May 26 14:04:13 CST 2013 > x86_64 GNU/Linux > root@debian-i386:/home/zwu/xfstests# > > - output mismatch (see /home/zwu/xfstests/results/btrfs/276.out.bad) > --- tests/btrfs/276.out 2013-05-25 15:09:01.000000000 +0000 > +++ /home/zwu/xfstests/results/btrfs/276.out.bad 2013-05-26 > 09:31:49.962876905 +0000 > @@ -1,3 +1,32393 @@ > QA output created by 276 > *** test backref walking > +FIBMAP: Invalid argument > +FIBMAP: Invalid argument > +FIBMAP: Invalid argument > +FIBMAP: Invalid argument > +FIBMAP: Invalid argument > ... > (Run 'diff -u tests/btrfs/276.out > /home/zwu/xfstests/results/btrfs/276.out.bad' to see the entire diff) > [ 3877.215268] device fsid 8367602a-14fa-49eb-aff0-44da1faa3b45 devid > 1 transid 239 /dev/vdb > [ 3877.218417] btrfs: disk space caching is enabled > Ran: btrfs/276 > Failures: btrfs/276 > Failed 1 of 1 tests > > On Wed, Mar 6, 2013 at 2:43 AM, Rich Johnston <rjohnston@sgi.com> wrote: >> This patch has been committed. >> >> --Rich >> >> commit eba3a5206cd7f8df73d6e6dbf2bb0afca677fca8 >> Author: Wang Sheng-Hui <shhuiw@gmail.com> >> Date: Thu Feb 28 02:05:56 2013 +0000 >> >> xfstests 276: fix error 'FIBMAP: Invalid argument' >> >> >> Commit 05dadc0 ("Btrfs: add fiemap's flag check") added validity >> checks to the fiemap flags and hence invalid flags are now being >> rejected. Test 276 passes an invalid fiemap flag to btrfs, and so >> that test fails since this commit was added. >> >> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by -x option >> of filefrag, and will fail with >> 'FIBMAP: Invalid argument' >> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with >> 'FIEMAP failed with unsupported flags 2' >> Remove the '-x' option. >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-05-26 17:35 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-02-27 7:15 [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' Wang Sheng-Hui 2013-02-27 23:04 ` Dave Chinner 2013-02-27 23:11 ` Eric Sandeen 2013-02-28 0:02 ` Wang Sheng-Hui 2013-02-28 0:25 ` Dave Chinner 2013-02-28 2:05 ` Wang Sheng-Hui 2013-03-05 18:43 ` Rich Johnston 2013-05-26 9:35 ` Zhi Yong Wu 2013-05-26 17:35 ` Eric Sandeen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).