From: Eric Sandeen <sandeen@redhat.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: usage should match what is coded
Date: Fri, 01 Mar 2013 11:47:50 -0600 [thread overview]
Message-ID: <5130E9C6.6000704@redhat.com> (raw)
In-Reply-To: <1362132602-29501-2-git-send-email-anand.jain@oracle.com>
On 3/1/13 4:10 AM, Anand Jain wrote:
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Revieed-by: Eric Sandeen <sandeen@redhat.com>
But the curious side of me wonders how it got this way.
commit e43cc461550130494194201037590a2b1f0f6880
Author: Ian Kumlien <pomac@demius.net>
Date: Fri Feb 8 01:37:02 2013 +0100
Btrfs-progs: add restore command to btrfs
added the usage text below, but didn't change the getopt
or add code to handle them.
No idea where it came from, it wasn't in the standalone
restore either. *shrug* I guess nothing got lost.
-Eric
> ---
> cmds-restore.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/cmds-restore.c b/cmds-restore.c
> index 9385042..4a14f93 100644
> --- a/cmds-restore.c
> +++ b/cmds-restore.c
> @@ -763,10 +763,6 @@ const char * const cmd_restore_usage[] = {
> "-f <offset> filesystem location",
> "-u <block> super mirror",
> "-d find dir",
> - "-r <num> root objectid",
> - "-c ignore case in regular expression",
> - "-m <regexp> regular expression to match",
> - "-l list roots",
> NULL
> };
>
>
next prev parent reply other threads:[~2013-03-01 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 10:10 [PATCH] btrfs-progs: from troubleshooting point of view messages must be unique Anand Jain
2013-03-01 10:10 ` [PATCH] btrfs-progs: usage should match what is coded Anand Jain
2013-03-01 17:47 ` Eric Sandeen [this message]
2013-03-01 18:05 ` Hugo Mills
2013-03-03 16:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130E9C6.6000704@redhat.com \
--to=sandeen@redhat.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).