From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
Stefan Behrens <sbehrens@giantdisaster.de>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Fix hang when mkfs.btrfs isn't present
Date: Wed, 6 Mar 2013 07:03:01 -0600 [thread overview]
Message-ID: <51373E85.9050408@sgi.com> (raw)
In-Reply-To: <513674B2.9030900@sandeen.net>
This patch has been committed.
Thanks
--Rich
commit 52f4953ac4a377f9f7fc870d2a81f30c3e5d3c7f
Author: Eric Sandeen <sandeen@sandeen.net>
Date: Tue Mar 5 22:41:54 2013 +0000
xfstests: Fix hang when mkfs.btrfs isn't present
My earlier patch (xfstests: handle new mkfs.btrfs -f option cleanly)
had a flaw in that if set_prog_path mkfs.btrfs returns nothing,
the grep will hang.
Test for that case to avoid it, and just return the empty string
in that case.
Reported-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
prev parent reply other threads:[~2013-03-06 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 20:42 [PATCH] xfstests: handle new mkfs.btrfs -f option cleanly Eric Sandeen
2013-03-05 20:23 ` Rich Johnston
2013-03-05 22:41 ` [PATCH] xfstests: Fix hang when mkfs.btrfs isn't present Eric Sandeen
2013-03-05 22:47 ` Rich Johnston
2013-03-06 13:03 ` Rich Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51373E85.9050408@sgi.com \
--to=rjohnston@sgi.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=sbehrens@giantdisaster.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).