From: Blair Zajac <blair@orcaware.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: enhance superblock checks
Date: Wed, 06 Mar 2013 09:14:45 -0800 [thread overview]
Message-ID: <51377985.603@orcaware.com> (raw)
In-Reply-To: <1362585400-13379-1-git-send-email-dsterba@suse.cz>
On 03/06/2013 07:56 AM, David Sterba wrote:
> The superblock checksum is not verified upon mount. <awkward silence>
>
> Add that check and also reorder existing checks to a more logical
> order.
>
> Current mkfs.btrfs does not calculate the correct checksum of
> super_block and thus a freshly created filesytem will fail to mount when
> this patch is applied.
>
> First transaction commit calculates correct superblock checksum and
> saves it to disk.
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 7d84651..d5c710c 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -354,6 +354,42 @@ out:
> }
>
> /*
> + * Return 0 if the superblock checksum type matches the checksum value of that
> + * alghorithm. Pass the raw disk superblock data.
I'm not familiar with the review policy on this list, but here's a minor
one:
s/alghorithm/algorithm/
Blair
next prev parent reply other threads:[~2013-03-06 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 15:56 [PATCH] btrfs: enhance superblock checks David Sterba
2013-03-06 16:32 ` [PATCH] btrfs-progs: separate super_copy out of fs_info David Sterba
2013-03-06 17:14 ` Blair Zajac [this message]
2013-03-06 18:33 ` [PATCH] btrfs: enhance superblock checks David Sterba
2013-03-06 18:56 ` Zach Brown
2013-03-07 14:52 ` David Sterba
2013-03-07 17:00 ` Zach Brown
2013-03-07 9:42 ` David Sterba
2013-03-08 13:15 ` [PATCH v2] " David Sterba
2013-03-13 19:31 ` Chris Mason
2013-03-15 11:22 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51377985.603@orcaware.com \
--to=blair@orcaware.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).