Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands

From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <esandeen@redhat.com>
Cc: Dave Chinner <david@fromorbit.com>,
	Eric Sandeen <sandeen@redhat.com>,
	Eric Sandeen <sandeen@sandeen.net>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands
Date: Fri, 15 Mar 2013 09:23:01 -0500	[thread overview]
Message-ID: <51432EC5.5090208@sgi.com> (raw)
In-Reply-To: <737235E6-72C8-45F5-A6F4-EEEFD094706E@redhat.com>

On 03/15/2013 08:46 AM, Eric Sandeen wrote:
> Yep sorry.  I figure its always a race in numbers do I don't bother with fixing them up.  Should I?
>

Eric,
I was going to revert and resubmit as test 306, is that OK with you?

> On Mar 15, 2013, at 5:16 AM, Dave Chinner <david@fromorbit.com> wrote:
>
>> On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote:
>>> Run basic btrfs information commands in various ways, performing
>>> sanity tests of: filesystem show, label, sync, and device stats
>>> (sync is included just because it's simple).  These are mostly
>>> just smoke tests, although for example show by label & UUID
>>> should verify that the correct fs was shown.
>>>
>>> This also add2730c49a3s quite a few new filters to accommodate the output
>>> of the new commands.
>>>
>>> Cc: linux-btrfs@vger.kernel.org
>>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>>> ---
>>>
>>> V2: sort & uniq device stats output to account for variable
>>> nrs. of devices.  Optionally check that the proper nr. of
>>> devices was returned, as well.
>>>
>>> V3: _filter_uuid needs to pay attention to $1, not hope
>>> that the caller has set $UUID.  Oops.
>>>
>>> V4: fix stats filter to set UNIQ_OPT in both cases, ugh.
>>
>> Something I just noticed in this commit:
>>
>>> +# get standard environment, filters and checks
>>> +. ./common.rc
>>> +. ./btrfs.filter
>>
>> That should probably have been named "common.filter.btrfs".

Dave,
Do you want me to rename btrfs.filter to common.filter.btrfs when I 
resubmit this patch?

Regards
--Rich

>> I found this updating my patchset that moves all the common.* files
>> into a common/ directory....
>>
>> I'll rename it to common/filter.btrfs....
>>
>> Cheers,
>>
>> Dave.
>> --
>> Dave Chinner
>> david@fromorbit.com
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>