linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com, chandan@mykolab.com
Subject: Re: [PATCH V2] Btrfs-progs: Do not force mixed block group creation unless '-M' option is specified
Date: Thu, 15 Oct 2015 13:26:33 +0530	[thread overview]
Message-ID: <5143356.m2iRuWGxTk@localhost.localdomain> (raw)
In-Reply-To: <561F05F1.4030409@cn.fujitsu.com>

On Thursday 15 Oct 2015 09:48:33 Qu Wenruo wrote:
> The mount failure also remind me about btrfs minimal size check.
> 
> Mkfs has its device check against nodesize by btrfs_min_dev_size() function.
> So this also means currect btrfs_min_dev_size() check is not good enough.
> 
> 
> Current code uses a quite simple one,
> 2 *(MKFS_SYSTEM_BLOCK_GROUP_SIZE + leaf_size << 10).
> But it still fails to be mounted.
> 
> Although not related to your patch, do you have any good calculation on
> the minimum device size?
>
Qu, Thanks for pointing this out. I missed out on this one. Currently I
have not got any numbers on arriving at a minimum device size. Will work on
that and post the results.

-- 
chandan


  reply	other threads:[~2015-10-15  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 17:39 [PATCH V2] Btrfs-progs: Do not force mixed block group creation unless '-M' option is specified Chandan Rajendra
2015-10-15  1:48 ` Qu Wenruo
2015-10-15  7:56   ` Chandan Rajendra [this message]
2015-10-19 16:52 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5143356.m2iRuWGxTk@localhost.localdomain \
    --to=chandan@linux.vnet.ibm.com \
    --cc=chandan@mykolab.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).