From: Wang Sheng-Hui <shhuiw@gmail.com>
To: Dave Chinner <dchinner@redhat.com>, xfstests <xfs@oss.sgi.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
Date: Mon, 25 Mar 2013 12:35:06 +0800 [thread overview]
Message-ID: <514FD3FA.701@gmail.com> (raw)
In-Reply-To: <514AA503.4060101@gmail.com>
On 2013年03月21日 14:13, Wang Sheng-Hui wrote:
> _require_nobigloopfs has been removed.
> We should use _require_no_large_scratch_dev in the test script.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> 276 | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/276 b/276
> index 40b30cf..87363ca 100755
> --- a/276
> +++ b/276
> @@ -58,8 +58,7 @@ _need_to_be_root
> _supported_fs btrfs
> _supported_os Linux
> _require_scratch
> -
> -_require_nobigloopfs
> +_require_no_large_scratch_dev
> _require_btrfs inspect-internal
> _require_command "/usr/sbin/filefrag"
>
Does anyone notice this?
I use the upstream xfstests and failed this case for the already-removed function.
I think someone patched in but mixed the old function.
I've send out this patch for days, but seems no one cares about it.
If I'm wrong, please let me know.
Thanks,
next prev parent reply other threads:[~2013-03-25 4:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 6:13 [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs Wang Sheng-Hui
2013-03-25 4:35 ` Wang Sheng-Hui [this message]
2013-03-25 13:43 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514FD3FA.701@gmail.com \
--to=shhuiw@gmail.com \
--cc=dchinner@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).