From: Eric Sandeen <sandeen@redhat.com>
To: Zach Brown <zab@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: abort unlink trans in missed error case
Date: Wed, 03 Apr 2013 11:18:12 -0500 [thread overview]
Message-ID: <515C5644.30705@redhat.com> (raw)
In-Reply-To: <20130403160418.GG2850@lenny.home.zabbo.net>
On 4/3/13 11:04 AM, Zach Brown wrote:
>>
>> I was wondering if the transaction support should just be in the
>> err: goto case, and went looking.
>
> Yeah, it's tempting. In the end I decided against it because this
> shouldn't be so willing to freak out and make the file system read only.
> It should try and undo the partial unlink and if *that* fails it should
> go read only. I went for the minimal fix for now.
>
>> I'm not familiar enough with this stuff yet, but what if i.e.
>> btrfs_delete_one_dir_name fails, should that also abort the
>> transaction?
>
> It doesn't abort because its the first thing that can fail. It can
> cleanly return an error without leaving partial state around.
>
> - z
>
Oh, sure. thanks -
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
prev parent reply other threads:[~2013-04-03 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 21:02 [PATCH] btrfs: abort unlink trans in missed error case Zach Brown
2013-04-03 14:36 ` Eric Sandeen
2013-04-03 16:04 ` Zach Brown
2013-04-03 16:18 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C5644.30705@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox