Re: btrfs-progs: re-add send-test

[Jan Schmidt <list.btrfs@jan-o-sch.net>]

On 09.04.2013 14:27, David Sterba wrote:
> On Tue, Apr 09, 2013 at 08:37:12AM +0200, Jan Schmidt wrote:
>> > On 06.04.2013 20:30, Eric Sandeen wrote:
>>> > > From: Mark Fasheh <mfasheh@suse.de>
>>> > > 
>>> > > btrfs-progs: re-add send-test
>>> > > 
>>> > > send-test.c links against libbtrfs and uses the send functionality provided
>>> > > to decode and print a send stream to the console.
>> > 
>> > This looks pretty much like fardump from Arne's far repository:
> AFAICS, send-test uses the NO_FILE_DATA mode, and the implementation
> differes (it calls into btrfs_read_and_process_send_stream, unlike
> fardump that dumps the attributes as it finds them), but the goal of the
> utility seems to be the same.

Good point, we will have to add something like NO_FILE_DATA to the far
lib (and probably even the zfs sender) as well.

> [snip]
>
> Are you fine with keeping send-test in btrfsprogs until then? It's not
> built by default so nobody will probably rely on it so it could get
> replaced by fardump eventually.

I'm absolutely fine with that. To make really sure we're not breaking
anything as soon as we organize things differently, I suggest prepending

+	printf("Output format is known to be changed. Do not rely on it. You have been warned.\n");

or the like, but I don't insist on it :-)

-Jan