From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] Btrfs: make some functions return type be void in backref.c
Date: Thu, 11 Apr 2013 15:14:39 +0800 [thread overview]
Message-ID: <516662DF.5080400@cn.fujitsu.com> (raw)
In-Reply-To: <20130410150110.GM18193@twin.jikos.cz>
Hello, David
Patch V2 has been sent out,many thanks for your review ^_^
Thanks,
Wang
> On Wed, Apr 10, 2013 at 07:22:51PM +0800, Wang Shilong wrote:
>> From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
>>
>> __merge_refs() and __add_missing_keys() always return 0, it is unnecessary
>> for the caller to check the return value.
>
> ok for __merge_refs, nak for __add_missing_keys: there's unhandled
> BUG_ON from read_tree_block
>
> 422 eb = read_tree_block(fs_info->tree_root, ref->wanted_disk_byte,
> 423 fs_info->tree_root->leafsize, 0);
> 424 BUG_ON(!eb);
>
> this should become a proper error handling someday and use the int return
> value. Keep the callers aware of that.
>
> david
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2013-04-11 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 11:22 [PATCH 0/2] cleanups when walking backref tree Wang Shilong
2013-04-10 11:22 ` [PATCH 1/2] Btrfs: remove some BUG_ONs() " Wang Shilong
2013-04-10 14:52 ` David Sterba
2013-04-10 11:22 ` [PATCH 2/2] Btrfs: make some functions return type be void in backref.c Wang Shilong
2013-04-10 15:01 ` David Sterba
2013-04-11 7:14 ` Wang Shilong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516662DF.5080400@cn.fujitsu.com \
--to=wangsl-fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox