From: Jan Schmidt <list.btrfs@jan-o-sch.net>
To: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Cc: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org,
wangshilong1991@gmail.com, dsterba@suse.cz
Subject: Re: [PATCH v3 2/3] Btrfs: rescan for qgroups
Date: Thu, 25 Apr 2013 17:04:33 +0200 [thread overview]
Message-ID: <51794601.2030009@jan-o-sch.net> (raw)
In-Reply-To: <517891E8.3060807@cn.fujitsu.com>
On Thu, April 25, 2013 at 04:16 (+0200), Wang Shilong wrote:
> I just have an example in my mind, considering the following example:
>
> qgroup(1/1)
> / \
> / \
> subv(257) snapshot(260)
> | /
> | /
> shared_extent
>
> For the above example, your code can make qgroup(1/1)'s exclusive correct?
>
> In your second step, you update every qgroup's referenced correct. But you only
> updte every qgroup's refcnt only once, so in your last step, you won't update qgroup
> (1/1)'s exlusive...Or am i missing someting ^_^
You're absolutely right. Will be fixed in v4. I only don't see how that could
possibly pass my previous tests.
Thanks,
-Jan
next prev parent reply other threads:[~2013-04-25 15:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 11:26 [PATCH v3 0/3] Btrfs: quota rescan for 3.10 Jan Schmidt
2013-04-23 11:26 ` [PATCH v3 1/3] Btrfs: split btrfs_qgroup_account_ref into four functions Jan Schmidt
2013-04-23 11:26 ` [PATCH v3 2/3] Btrfs: rescan for qgroups Jan Schmidt
2013-04-23 11:43 ` Wang Shilong
2013-04-23 12:05 ` Wang Shilong
2013-04-23 13:03 ` Jan Schmidt
2013-04-23 14:54 ` Wang Shilong
2013-04-23 17:33 ` Jan Schmidt
2013-04-24 11:00 ` Wang Shilong
2013-04-24 15:20 ` Jan Schmidt
2013-04-25 2:16 ` Wang Shilong
2013-04-25 15:04 ` Jan Schmidt [this message]
2013-04-23 11:26 ` [PATCH v3 3/3] Btrfs: automatic rescan after "quota enable" command Jan Schmidt
2013-04-23 15:36 ` David Sterba
2013-04-23 15:47 ` David Sterba
2013-04-23 17:28 ` Jan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51794601.2030009@jan-o-sch.net \
--to=list.btrfs@jan-o-sch.net \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
--cc=wangsl-fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox