From: Anand Jain <Anand.Jain@oracle.com>
To: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: device delete to get errors from the kernel
Date: Tue, 30 Apr 2013 21:17:57 +0800 [thread overview]
Message-ID: <517FC485.3080208@oracle.com> (raw)
In-Reply-To: <517A4B44.5060608@oracle.com>
Thanks for the comments. V2 is out. Here I followed
the choice #1 as review suggested. which is to update
the error code. However I have them in uapi/linux/btrfs.h
(not in errno.h though I meant it to be there in the first
place).
pls do let me know your review comments.
Thanks, Anand
On 04/26/2013 05:39 PM, Anand Jain wrote:
>
> As showed in the previous email in this thread, we need to get
> the error string from the kernel to the cli to improve the
> usability of the product.
> As also said, I was looking at two way which I think we could
> do this, here I take the 2nd approach which is to pass the error
> string though the ioctl args. Which leads to change in the
> ioctl-structure. But..
>
> This comes with a caveat that both btrfs-progs and btrfs-kernel
> patch together either must be applied or removed.
>
> [PATCH] btrfs-progs: device delete to get errors from the kernel
> [PATCH] btrfs: device delete to get errors from the kernel
>
> Which is not a developer/integrator friendly rule. If there
> is anything I could do to help on this pls do let me know.
>
> There are quite a number of cli which needs passing of the
> the error string from the kernel to cli. Which I plan to work
> once we finalize the approach to address this issue.
>
> Thanks for your time to review this.
>
> Anand
next prev parent reply other threads:[~2013-04-30 13:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 3:39 [bug] error communication from kernel to userland Anand Jain
2013-04-26 9:39 ` device delete to get errors from the kernel Anand Jain
2013-04-26 9:41 ` [PATCH] btrfs-progs: " Anand Jain
2013-04-26 9:41 ` [PATCH] btrfs: " Anand Jain
2013-04-29 19:12 ` Josef Bacik
2013-04-30 5:55 ` Anand Jain
2013-04-26 10:51 ` Stefan Behrens
2013-04-30 6:14 ` Anand Jain
2013-04-30 13:17 ` Anand Jain [this message]
2013-04-30 13:19 ` [PATCH v2] btrfs: " Anand Jain
2013-04-30 13:19 ` [PATCH v2] btrfs-progs: " Anand Jain
2013-05-17 10:53 ` [PATCH v3] " Anand Jain
2013-05-06 19:39 ` [PATCH v2] btrfs: " Josef Bacik
2013-05-17 10:52 ` [PATCH v3] " Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FC485.3080208@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox