From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 1/2] btrfs: remove the alignment check in end_bbio_data_write()
Date: Tue, 3 Mar 2026 18:45:09 +1030 [thread overview]
Message-ID: <51818a7c1233086fe42a3e7a18cf6a144ef14513.1772525669.git.wqu@suse.com> (raw)
In-Reply-To: <cover.1772525669.git.wqu@suse.com>
The check is not necessary because:
- There is already assert_bbio_alignment() at btrfs_submit_bbio()
- There is also btrfs_subpage_assert() for all btrfs_folio_*() helpers
- No similar check in all other endio functions
No matter if it's data read, compressed read or write.
- There is no such report for very long
I do not even remember if there is any such report.
Thus the need to do such check in end_bbio_data_write() is very weak,
and we can just get rid of it.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/extent_io.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 33b1afbee0a6..de6e25475ce1 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -520,7 +520,6 @@ static void end_bbio_data_write(struct btrfs_bio *bbio)
struct bio *bio = &bbio->bio;
int error = blk_status_to_errno(bio->bi_status);
struct folio_iter fi;
- const u32 sectorsize = fs_info->sectorsize;
u32 bio_size = 0;
ASSERT(!bio_flagged(bio, BIO_CLONED));
@@ -530,16 +529,6 @@ static void end_bbio_data_write(struct btrfs_bio *bbio)
u32 len = fi.length;
bio_size += len;
- /* Our read/write should always be sector aligned. */
- if (!IS_ALIGNED(fi.offset, sectorsize))
- btrfs_err(fs_info,
- "partial page write in btrfs with offset %zu and length %zu",
- fi.offset, fi.length);
- else if (!IS_ALIGNED(fi.length, sectorsize))
- btrfs_info(fs_info,
- "incomplete page write with offset %zu and length %zu",
- fi.offset, fi.length);
-
if (error)
mapping_set_error(folio->mapping, error);
--
2.53.0
next prev parent reply other threads:[~2026-03-03 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:15 [PATCH 0/2] btrfs: trivial cleanups in end_bbio_data_write() Qu Wenruo
2026-03-03 8:15 ` Qu Wenruo [this message]
2026-03-04 3:20 ` [PATCH 1/2] btrfs: remove the alignment check " David Sterba
2026-03-03 8:15 ` [PATCH 2/2] btrfs: move the mapping_set_error() out of the loop " Qu Wenruo
2026-03-04 3:29 ` [PATCH 0/2] btrfs: trivial cleanups " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51818a7c1233086fe42a3e7a18cf6a144ef14513.1772525669.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox