From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:34033 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753353Ab3EIB7f (ORCPT ); Wed, 8 May 2013 21:59:35 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r491xZ1X020633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 May 2013 21:59:35 -0400 Received: from liberator.sandeen.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r491xXaC015810 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 8 May 2013 21:59:35 -0400 Message-ID: <518B0305.6090705@redhat.com> Date: Wed, 08 May 2013 20:59:33 -0500 From: Eric Sandeen MIME-Version: 1.0 To: linux-btrfs Subject: Re: [PATCH] blktrace: document -k option References: <518AFCE3.6080307@redhat.com> In-Reply-To: <518AFCE3.6080307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 5/8/13 8:33 PM, Eric Sandeen wrote: > the -k option was missing from the usage() output and was present > only in the man page synopsis. Say a few more words about it. Gah, sorry. email address auto-fill bit me. :( > Signed-off-by: Eric Sandeen > --- > > diff --git a/blktrace.c b/blktrace.c > index 89aaaac..4e96573 100644 > --- a/blktrace.c > +++ b/blktrace.c > @@ -450,6 +450,7 @@ static char usage_str[] = "\n\n" \ > "[ -p | --port=]\n" \ > "[ -s | --no-sendfile]\n" \ > "[ -I | --input-devs=]\n" \ > + "[ -k | --kill]\n" \ > "[ -v | --version]\n" \ > "[ -V | --version]\n" \ > > @@ -467,6 +468,7 @@ static char usage_str[] = "\n\n" \ > "\t-p Network port to use (default 8462)\n" \ > "\t-s Make the network client NOT use sendfile() to transfer data\n" \ > "\t-I Add devices found in \n" \ > + "\t-k Kill a running trace\n" \ > "\t-v Print program version info\n" \ > "\t-V Print program version info\n\n"; > > diff --git a/doc/blktrace.8 b/doc/blktrace.8 > index b5e69b7..7f13231 100644 > --- a/doc/blktrace.8 > +++ b/doc/blktrace.8 > @@ -163,6 +163,13 @@ This only works when supplying a single device, or when piping the output > via "-o -" with multiple devices. > .RE > > +\-k > +.br > +\-\-kill > +.RS > +Kill a running trace if blktrace dies > +.RE > + > \-r \fIrel-path\fR > .br > \-\-relay=\fIrel-path\fR > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >