From: Andreas Philipp <philipp.andreas@gmail.com>
To: linux-btrfs@vger.kernel.org, "Hugo Mills" <hugo@carfax.org.uk>,
"Marcus Lövgren" <marcuslvgrn@gmail.com>,
"Remco Hosman - Yerf IT" <remco@yerf-it.nl>
Cc: Andreas Philipp <philipp.andreas@gmail.com>,
Chris Mason <chris.mason@fusionio.com>
Subject: [PATCH RESEND 2/2] Correct allowed raid levels on balance.
Date: Sat, 11 May 2013 13:13:03 +0200 [thread overview]
Message-ID: <518E27BF.8000507@gmail.com> (raw)
In-Reply-To: <cover.1360786935.git.philipp.andreas@gmail.com>
In-Reply-To: 518E278D.6070508@gmail.com
Raid5 with 3 devices is well defined while the old logic allowed
raid5 only with a minimum of 4 devices when converting the block group
profile via btrfs balance. Creating a raid5 with just three devices
using mkfs.btrfs worked always as expected. This is now fixed and the
whole logic is rewritten.
Signed-off-by: Andreas Philipp <philipp.andreas@gmail.com>
---
fs/btrfs/volumes.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 8818dc3..6885165 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -3046,13 +3046,12 @@ int btrfs_balance(struct btrfs_balance_control
*bctl,
allowed = BTRFS_AVAIL_ALLOC_BIT_SINGLE;
if (num_devices == 1)
allowed |= BTRFS_BLOCK_GROUP_DUP;
- else if (num_devices < 4)
+ if (num_devices > 1)
allowed |= (BTRFS_BLOCK_GROUP_RAID0 | BTRFS_BLOCK_GROUP_RAID1);
- else
- allowed |= (BTRFS_BLOCK_GROUP_RAID0 | BTRFS_BLOCK_GROUP_RAID1 |
- BTRFS_BLOCK_GROUP_RAID10 |
- BTRFS_BLOCK_GROUP_RAID5 |
- BTRFS_BLOCK_GROUP_RAID6);
+ if (num_devices > 2)
+ allowed |= BTRFS_BLOCK_GROUP_RAID5;
+ if (num_devices > 3)
+ allowed |= (BTRFS_BLOCK_GROUP_RAID10 | BTRFS_BLOCK_GROUP_RAID6);
if ((bctl->data.flags & BTRFS_BALANCE_ARGS_CONVERT) &&
(!alloc_profile_is_valid(bctl->data.target, 1) ||
--
1.7.12.4
prev parent reply other threads:[~2013-05-11 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 20:59 [PATCH 0/2] Two small patches for the raid56 code Andreas Philipp
2013-02-13 20:59 ` [PATCH 1/2] Minor format cleanup Andreas Philipp
2013-02-13 20:59 ` [PATCH 2/2] Correct allowed raid levels on balance Andreas Philipp
2013-05-11 11:12 ` [PATCH RESEND 1/2] Minor format cleanup Andreas Philipp
2013-05-11 11:13 ` Andreas Philipp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518E27BF.8000507@gmail.com \
--to=philipp.andreas@gmail.com \
--cc=chris.mason@fusionio.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcuslvgrn@gmail.com \
--cc=remco@yerf-it.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).