From: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/5] Btrfs: don't abort the current transaction if there is no enough space for inode cache
Date: Tue, 14 May 2013 15:39:28 +0900 [thread overview]
Message-ID: <5191DC20.704@jp.fujitsu.com> (raw)
In-Reply-To: <1368453312-7027-1-git-send-email-miaox@cn.fujitsu.com>
Hi, Miao,
On 2013/05/13 22:55, Miao Xie wrote:
> The filesystem with inode cache was forced to be read-only when we umounted it.
>
> Steps to reproduce:
> # mkfs.btrfs -f ${DEV}
> # mount -o inode_cache ${DEV} ${MNT}
> # dd if=/dev/zero of=${MNT}/file1 bs=1M count=8192
> # btrfs fi syn ${MNT}
> # dd if=${MNT}/file1 of=/dev/null bs=1M
> # rm -f ${MNT}/file1
> # btrfs fi syn ${MNT}
> # umount ${MNT}
>
> It is because there was no enough space to do inode cache truncation, and then
> we aborted the current transaction.
The problem has not occurred in my testset after applying your patchset.
Your patchset looks good to me. Thanks.
Tested-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
>
> But no space error is not a serious problem when we write out the inode cache,
> and it is safe that we just skip this step if we meet this problem. So we need
> not abort the current transaction.
>
> Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
> ---
> fs/btrfs/inode-map.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c
> index d26f67a..9818d4a 100644
> --- a/fs/btrfs/inode-map.c
> +++ b/fs/btrfs/inode-map.c
> @@ -468,7 +468,8 @@ again:
> if (i_size_read(inode) > 0) {
> ret = btrfs_truncate_free_space_cache(root, trans, path, inode);
> if (ret) {
> - btrfs_abort_transaction(trans, root, ret);
> + if (ret != -ENOSPC)
> + btrfs_abort_transaction(trans, root, ret);
> goto out_put;
> }
> }
>
prev parent reply other threads:[~2013-05-14 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 13:55 [PATCH 1/5] Btrfs: don't abort the current transaction if there is no enough space for inode cache Miao Xie
2013-05-13 13:55 ` [PATCH 2/5] Btrfs: don't use global block reservation for inode cache truncation Miao Xie
2013-05-13 13:55 ` [PATCH 3/5] Btrfs: optimize the error handle of use_block_rsv() Miao Xie
2013-05-13 13:55 ` [PATCH 4/5] Btrfs: don't steal the reserved space from the global reserve if their space type is different Miao Xie
2013-05-13 13:55 ` [PATCH 5/5] Btrfs: update the global reserve if it is empty Miao Xie
2013-05-14 6:39 ` Tsutomu Itoh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5191DC20.704@jp.fujitsu.com \
--to=t-itoh@jp.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).