linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* btrfs-progs and btrfs code similar why ?
@ 2013-06-13  3:56 Anand Jain
  2013-06-13  4:44 ` Eric Sandeen
  0 siblings, 1 reply; 3+ messages in thread
From: Anand Jain @ 2013-06-13  3:56 UTC (permalink / raw)
  To: linux-btrfs



   Per wiki an idea seems to maintain same code (probably
   as much as possible) between btrfs-progs and btrfs

   There must have been a/few critical advantage, but
   what are they ?

Thanks, Anand



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: btrfs-progs and btrfs code similar why ?
  2013-06-13  3:56 btrfs-progs and btrfs code similar why ? Anand Jain
@ 2013-06-13  4:44 ` Eric Sandeen
  2013-06-14  1:53   ` Anand Jain
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2013-06-13  4:44 UTC (permalink / raw)
  To: Anand Jain; +Cc: linux-btrfs

On 6/12/13 10:56 PM, Anand Jain wrote:
> 
> 
>   Per wiki an idea seems to maintain same code (probably
>   as much as possible) between btrfs-progs and btrfs
> 
>   There must have been a/few critical advantage, but
>   what are they ?
> 
> Thanks, Anand

Because they work with the same on-disk structures, and need
to perform many of the same tasks.  So using the same code base
means bugs get fixed once, features get written once, there is
built-in consistency, more coverage, etc.

I was just looking at an ext4 bug tonight where offline vs.
online resize result in different filesystem images.  In one
case it leads to a bug, in the other it doesn't.  The complex
resize code is implemented twice, and implemented differently.

Less code is good.  Consistency is good.

-Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: btrfs-progs and btrfs code similar why ?
  2013-06-13  4:44 ` Eric Sandeen
@ 2013-06-14  1:53   ` Anand Jain
  0 siblings, 0 replies; 3+ messages in thread
From: Anand Jain @ 2013-06-14  1:53 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-btrfs


> Because they work with the same on-disk structures, and need
> to perform many of the same tasks.  So using the same code base
> means bugs get fixed once, features get written once, there is
> built-in consistency, more coverage, etc.

  yes. Thanks Eric.

- Anand

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-14  1:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13  3:56 btrfs-progs and btrfs code similar why ? Anand Jain
2013-06-13  4:44 ` Eric Sandeen
2013-06-14  1:53   ` Anand Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).