From: Anand Jain <Anand.Jain@oracle.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] Btrfs-progs: remove unused code
Date: Mon, 01 Jul 2013 16:21:52 +0800 [thread overview]
Message-ID: <51D13C20.1050104@oracle.com> (raw)
In-Reply-To: <1372593106-6593-4-git-send-email-fdmanana@gmail.com>
good catch.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
On 06/30/2013 07:51 PM, Filipe David Borba Manana wrote:
> The uuid_unparse() call in btrfs_scan_one_device() was
> a no-op.
>
>
> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
> ---
> volumes.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/volumes.c b/volumes.c
> index ea1d401..9d5e97e 100644
> --- a/volumes.c
> +++ b/volumes.c
> @@ -223,7 +223,6 @@ int btrfs_scan_one_device(int fd, const char *path,
> char *buf;
> int ret;
> u64 devid;
> - char uuidbuf[37];
>
> buf = malloc(4096);
> if (!buf) {
> @@ -241,7 +240,6 @@ int btrfs_scan_one_device(int fd, const char *path,
> *total_devs = 1;
> else
> *total_devs = btrfs_super_num_devices(disk_super);
> - uuid_unparse(disk_super->fsid, uuidbuf);
>
> ret = device_list_add(path, disk_super, devid, fs_devices_ret);
>
>
next prev parent reply other threads:[~2013-07-01 8:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 11:51 [PATCH 0/3] Small fixes for btrfs-progs Filipe David Borba Manana
2013-06-30 11:51 ` [PATCH 1/3] Btrfs-progs: add missing write check for mkfs Filipe David Borba Manana
2013-07-03 17:09 ` David Sterba
2013-07-03 17:25 ` Filipe David Manana
2013-07-03 21:12 ` David Sterba
2013-06-30 11:51 ` [PATCH 2/3] Btrfs-progs: add kstrdup() return value check Filipe David Borba Manana
2013-06-30 11:51 ` [PATCH 3/3] Btrfs-progs: remove unused code Filipe David Borba Manana
2013-07-01 8:21 ` Anand Jain [this message]
2013-07-03 17:30 ` [PATCH v2 1/3] Btrfs-progs: add missing write check for mkfs Filipe David Borba Manana
2013-07-03 17:32 ` [PATCH v2 3/3] Btrfs-progs: remove unused code Filipe David Borba Manana
2013-07-04 9:48 ` [PATCH v2 0/5] Small fixes for btrfs-progs Filipe David Borba Manana
2013-07-04 9:48 ` [PATCH 4/5] Btrfs-progs: return error on write failure in make_btrfs() Filipe David Borba Manana
2013-08-08 10:52 ` Stefan Behrens
2013-08-08 10:56 ` Filipe David Manana
2013-07-04 9:48 ` [PATCH 5/5] Btrfs-progs: don't ignore errors in btrfs_add_block_group() Filipe David Borba Manana
2013-07-08 13:21 ` [PATCH v2 5/5] Btrfs-progs: don't ignore errors in extent-tree.c Filipe David Borba Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D13C20.1050104@oracle.com \
--to=anand.jain@oracle.com \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).