From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Cleanup for using BTRFS_SETGET_STACK instead of raw convert
Date: Tue, 09 Jul 2013 09:18:13 +0800 [thread overview]
Message-ID: <51DB64D5.90807@cn.fujitsu.com> (raw)
In-Reply-To: <20130708132455.GA18204@twin.jikos.cz>
于 2013年07月08日 21:24, David Sterba 写道:
> On Fri, Jul 05, 2013 at 10:01:30AM +0800, Qu Wenruo wrote:
>> --- a/fs/btrfs/ctree.h
>> +++ b/fs/btrfs/ctree.h
>> @@ -2807,6 +2846,14 @@ static inline unsigned long btrfs_leaf_data(struct extent_buffer *l)
>>
>> /* struct btrfs_file_extent_item */
>> BTRFS_SETGET_FUNCS(file_extent_type, struct btrfs_file_extent_item, type, 8);
>> +BTRFS_SETGET_STACK_FUNCS(stack_file_extent_bytenr,
>> + struct btrfs_file_extent_item, disk_bytenr, 64);
> Please use the struct member name in the macro name, ie.
> stack_file_extent_disk_bytenr
Thanks for pointing out the problem.
I'll change the macro name and send a new patch.
>
> otherwise ok,
> Reviewed-by: David Sterba <dsterba@suse.cz>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
-----------------------------------------------------
Qu Wenruo
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8526
COINS: 7998-8526
FAX: +86+25-83317685
MAIL: quwenruo@cn.fujitsu.com
-----------------------------------------------------
prev parent reply other threads:[~2013-07-09 1:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 2:01 [PATCH] btrfs: Cleanup for using BTRFS_SETGET_STACK instead of raw convert Qu Wenruo
2013-07-08 13:24 ` David Sterba
2013-07-09 1:18 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DB64D5.90807@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).