linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <Anand.Jain@oracle.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix get set label blocking against balance
Date: Fri, 19 Jul 2013 17:31:49 +0800	[thread overview]
Message-ID: <51E90785.9070402@oracle.com> (raw)
In-Reply-To: <51E7E3E3.9000008@giantdisaster.de>



> Instead the spinlock super_lock looks appropriate for
> protecting concurrent access to the label field of fs_info->super_copy.
> In btrfs_ioctl_set_fslabel() make sure to only hold the spinlock for the
> copy operation, not while calling the transaction functions.

  Oh yeah ! fs_info->super_lock is most suitable.
  its right there. Thanks.

  New patch has been sent out.

Thanks.
Anand

  reply	other threads:[~2013-07-19  9:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17  8:29 [bug] label cli hangs until balance is completed Anand Jain
2013-07-17  9:09 ` Stefan Behrens
2013-07-17 17:49   ` Zach Brown
2013-07-18 11:18 ` [PATCH] btrfs: fix get set label blocking against balance Anand Jain
2013-07-18 12:47   ` Stefan Behrens
2013-07-19  9:31     ` Anand Jain [this message]
2013-07-19  9:39   ` [PATCH v2] " Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E90785.9070402@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sbehrens@giantdisaster.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).