linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Ben Myers <bpm@sgi.com>
Cc: Josef Bacik <jbacik@fusionio.com>,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: exit out if _scratch_mount fails
Date: Fri, 26 Jul 2013 11:58:13 -0500	[thread overview]
Message-ID: <51F2AAA5.5010101@sandeen.net> (raw)
In-Reply-To: <20130726163352.GL1681@sgi.com>

On 7/26/13 11:33 AM, Ben Myers wrote:
> Josef, Eric,
> 
> On Fri, Jul 26, 2013 at 11:15:13AM -0500, Eric Sandeen wrote:
>> On 7/26/13 11:12 AM, Ben Myers wrote:
>>> Hey Josef,
>>>
>>> On Tue, Jul 09, 2013 at 03:07:27PM -0400, Josef Bacik wrote:
>>>> I test some of the different mkfs options for btrfs, one set doesn't work
>>>> properly with small file systems, so the fs won't mount.  This is fine from a
>>>> btrfs point of view, but tests that fail to mount the scratch fs will run
>>>> anyway, so if it's a "fill the fs" sort of test this will wreak havoc.  To fix
>>>> this just error out of _scratch_mount fails.  Thanks,
>>>>
>>>> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
>>>
>>> I noticed that this change causes dmapi tests to try to be run on systems that
>>> don't have dmapi supported, and they fail.  Have you seen this?
>>>
>>> Thanks,
>>> 	Ben
>>
>> I haven't tested either way, but does:
>>
>>      _mount -t $FSTYP `_scratch_mount_options $*` || _fail "Scratch mount failed"
>>
>> work any better?
> 
> This still fails like so:
> 
> xfs/142  [failed, exit status 1] - output mismatch (see /root/xfstests/results/xfs/142.out.bad)
> --- tests/xfs/142.out       2013-05-17 14:23:16.000000000 -0500
> +++ /root/xfstests/results/xfs/142.out.bad  2013-07-26 11:31:00.128200302 -0500
> @@ -1,232 +1,8 @@
> QA output created by 142
> -Attribute tests beginning...
> -Report: success with set #0.
> -Report: success with set #1.
> -Report: success with set #2.
> -Report: success with set #3.
> -Report: success with set #4.
> ...
> (Run 'diff -u tests/xfs/142.out /root/xfstests/results/xfs/142.out.bad' to see the entire diff)

Hm, well, _dmapi_scratch_mount tries a mount, and then does a _notrun if that fails.

Josef's patch calls a _fail (or an exit) if mount fails, and it never gets to "notrun"
in _dmapi_scratch_mount.

So for this test it's an expected mount failure, which changes things a bit.

Still, not quite sure why the test continues after either exit 1 or _fail.

But my bash is rusty...

-Eric

> Thanks,
> 	Ben
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 


           reply	other threads:[~2013-07-26 16:58 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20130726163352.GL1681@sgi.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F2AAA5.5010101@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bpm@sgi.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).