From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Josef Bacik <jbacik@fusionio.com>,
jeff.liu@oracle.com, linux-btrfs@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: generic/315: add one more sync and more output
Date: Mon, 29 Jul 2013 12:38:25 -0500 [thread overview]
Message-ID: <51F6A891.7070608@sandeen.net> (raw)
In-Reply-To: <51F6A6DA.3080102@redhat.com>
On 7/29/13 12:31 PM, Eric Sandeen wrote:
> Honest question: does one more sync make this deterministic, or is it a best-effort, um, hack?
I'm not quite sure why even 1 sync is needed. :(
I'm not sure what bug this is trying to test; if you need 2 syncs for global space stats to accurately reflect the fact that you chopped off the end of a block, maybe that's ... still a bug?
Or if it's just the big-hammer question of "does the truncated space *ever* get freed?" then maybe umount/remount/check would tell you that more definitively.
-Eric
next prev parent reply other threads:[~2013-07-29 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 17:21 [PATCH] xfstests: generic/315: add one more sync and more output Josef Bacik
2013-07-29 17:31 ` Eric Sandeen
2013-07-29 17:38 ` Eric Sandeen [this message]
2013-07-29 18:25 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F6A891.7070608@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jbacik@fusionio.com \
--cc=jeff.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).