From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo-p05-ob.rzone.de ([81.169.146.182]:38527 "EHLO mo-p05-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757638Ab3HHHdi (ORCPT ); Thu, 8 Aug 2013 03:33:38 -0400 Message-ID: <520349BA.8080006@gmx.net> Date: Thu, 08 Aug 2013 09:33:14 +0200 From: Arne Jansen MIME-Version: 1.0 To: Sergei Trofimovich CC: linux-btrfs@vger.kernel.org, Chris Mason , Josef Bacik , linux-kernel@vger.kernel.org, Sergei Trofimovich Subject: Re: [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach' References: <1375911803-17318-1-git-send-email-slyich@gmail.com> <1375911803-17318-7-git-send-email-slyich@gmail.com> In-Reply-To: <1375911803-17318-7-git-send-email-slyich@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 07.08.2013 23:43, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Found by uselex.rb: >> btrfs_reada_detach: [R]: exported from: fs/btrfs/btrfs.o fs/btrfs/built-in.o fs/btrfs/reada.o even though the function is currently unused, I'm hesitating to remove it as it's part of the reada-API and might be handy for anyone going to use the API in the future. -Arne > > Signed-off-by: Sergei Trofimovich > --- > fs/btrfs/ctree.h | 1 - > fs/btrfs/reada.c | 9 +-------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index e91ab9e..f35e086 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -3861,7 +3861,6 @@ struct reada_control { > struct reada_control *btrfs_reada_add(struct btrfs_root *root, > struct btrfs_key *start, struct btrfs_key *end); > int btrfs_reada_wait(void *handle); > -void btrfs_reada_detach(void *handle); > int btree_readahead_hook(struct btrfs_root *root, struct extent_buffer *eb, > u64 start, int err); > > diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c > index 1031b69..c41d470 100644 > --- a/fs/btrfs/reada.c > +++ b/fs/btrfs/reada.c > @@ -37,7 +37,7 @@ > * To trigger a readahead, btrfs_reada_add must be called. It will start > * a read ahead for the given range [start, end) on tree root. The returned > * handle can either be used to wait on the readahead to finish > - * (btrfs_reada_wait), or to send it to the background (btrfs_reada_detach). > + * (btrfs_reada_wait). > * > * The read ahead works as follows: > * On btrfs_reada_add, the root of the tree is inserted into a radix_tree. > @@ -979,10 +979,3 @@ int btrfs_reada_wait(void *handle) > return 0; > } > #endif > - > -void btrfs_reada_detach(void *handle) > -{ > - struct reada_control *rc = handle; > - > - kref_put(&rc->refcnt, reada_control_release); > -}