From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: fdmanana@gmail.com
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] Btrfs: catch error return value from find_extent_in_eb()
Date: Thu, 08 Aug 2013 19:01:10 +0800 [thread overview]
Message-ID: <52037A76.3000707@cn.fujitsu.com> (raw)
In-Reply-To: <CAL3q7H77CCD9saViLZukwHtmi3=PHkxiOy4rc+z1ftvHfOuK=w@mail.gmail.com>
On 08/08/2013 06:24 PM, Filipe David Manana wrote:
> On Thu, Aug 8, 2013 at 6:04 AM, Wang Shilong <wangsl.fnst@cn.fujitsu.com> wrote:
>> find_extent_in_eb() may return ENOMEM, catch this error return value.
>>
>> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
>> Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>
>> ---
>> fs/btrfs/backref.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
>> index 54e7610..f7781e6 100644
>> --- a/fs/btrfs/backref.c
>> +++ b/fs/btrfs/backref.c
>> @@ -934,6 +934,10 @@ again:
>> }
>> ret = find_extent_in_eb(eb, bytenr,
>> *extent_item_pos, &eie);
>> + if (ret) {
>> + free_extent_buffer(eb);
>> + goto out;
>> + }
>> ref->inode_list = eie;
>> free_extent_buffer(eb);
>> }
>
> Hello, this is a duplicate of: https://patchwork.kernel.org/patch/2835989/
Yeah, just ignore my patch.
Thanks,
Wang
>
> thanks
>
next prev parent reply other threads:[~2013-08-08 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 5:04 [PATCH 1/3] Btrfs: fix possible memory leak in find_parent_nodes() Wang Shilong
2013-08-08 5:04 ` [PATCH 2/3] Btrfs: catch error return value from find_extent_in_eb() Wang Shilong
2013-08-08 10:24 ` Filipe David Manana
2013-08-08 11:01 ` Wang Shilong [this message]
2013-08-08 11:06 ` Jan Schmidt
2013-08-08 5:04 ` [PATCH 3/3] Btrfs: allocate prelim_ref with a slab allocater Wang Shilong
2013-08-08 11:25 ` Jan Schmidt
2013-08-08 11:39 ` Wang Shilong
2013-08-08 14:19 ` David Sterba
2013-08-08 5:18 ` [PATCH 1/3] Btrfs: fix possible memory leak in find_parent_nodes() Liu Bo
2013-08-08 5:22 ` Liu Bo
2013-08-08 5:37 ` Miao Xie
2013-08-08 11:02 ` Jan Schmidt
2013-08-08 11:02 ` Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52037A76.3000707@cn.fujitsu.com \
--to=wangsl.fnst@cn.fujitsu.com \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).