From: Arne Jansen <sensille@gmx.net>
To: Zach Brown <zab@redhat.com>
Cc: dsterba@suse.cz, Sergei Trofimovich <slyich@gmail.com>,
linux-btrfs@vger.kernel.org,
Chris Mason <chris.mason@fusionio.com>,
Josef Bacik <jbacik@fusionio.com>,
linux-kernel@vger.kernel.org,
Sergei Trofimovich <slyfox@gentoo.org>
Subject: Re: [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach'
Date: Thu, 08 Aug 2013 21:11:01 +0200 [thread overview]
Message-ID: <5203ED45.3090604@gmx.net> (raw)
In-Reply-To: <20130808174657.GV12314@lenny.home.zabbo.net>
On 08/08/13 19:46, Zach Brown wrote:
>>> even though the function is currently unused, I'm hesitating to remove it
>>> as it's part of the reada-API and might be handy for anyone going to use
>>> the API in the future.
>>
>> I agree. As replied here,
>> http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg24047.html
>> please keep the function.
>
> If we're keeping score, put me down for being in favour of removing dead
> untested code. git ressurection is easy.
It's not really untested, it has been in use some time ago. But of
course there's a chance that some changes broke it.
Yes, git ressurection is easy. To inform potential users, you might
just leave a comment like this:
/*
* There has been a function once to detach from a running reada.
* If you need such functionality, just revert the commit that
* added this comment.
*/
-Arne
>
> - z
>
next prev parent reply other threads:[~2013-08-08 19:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 21:43 [PATCH 0/7] uselex.rb as a tiny tool to find dead code Sergei Trofimovich
2013-08-07 21:43 ` [PATCH 1/7] btrfs: cleanup: mark 'btrfs_lookup_fs_root' as static Sergei Trofimovich
2013-08-07 21:43 ` [PATCH 2/7] btrfs: cleanup: mark 'set_state_private' " Sergei Trofimovich
2013-08-07 21:43 ` [PATCH 3/7] btrfs: cleanup: mark 'btrfs_write_and_wait_marked_extents' " Sergei Trofimovich
2013-08-08 13:39 ` David Sterba
2013-08-07 21:43 ` [PATCH 4/7] btrfs: cleanup: removed unused 'btrfs_start_transaction_lflush' Sergei Trofimovich
2013-08-08 13:32 ` David Sterba
2013-08-07 21:43 ` [PATCH 5/7] btrfs: cleanup: mark 'btrfs_read_root_item' as static Sergei Trofimovich
2013-08-07 21:43 ` [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach' Sergei Trofimovich
2013-08-08 7:33 ` Arne Jansen
2013-08-08 13:26 ` David Sterba
2013-08-08 17:46 ` Zach Brown
2013-08-08 19:11 ` Arne Jansen [this message]
2013-08-08 22:00 ` David Sterba
2013-08-07 21:43 ` [PATCH 7/7] btrfs: cleanup: removed unused 'btrfs_get_inode_ref_index' Sergei Trofimovich
2013-08-08 14:02 ` David Sterba
2013-08-07 22:02 ` [PATCH 0/7] uselex.rb as a tiny tool to find dead code Eric Sandeen
2013-08-07 22:13 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203ED45.3090604@gmx.net \
--to=sensille@gmx.net \
--cc=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slyfox@gentoo.org \
--cc=slyich@gmail.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).