From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, sensille@gmx.net, miaox@cn.fujitsu.com
Subject: Re: [PATCH 1/3] Btrfs: fix oops when writing dirty qgroups to disk
Date: Fri, 09 Aug 2013 17:12:24 +0800 [thread overview]
Message-ID: <5204B278.4010506@cn.fujitsu.com> (raw)
In-Reply-To: <20130808132033.GD16712@localhost.localdomain>
On 08/08/2013 09:20 PM, Josef Bacik wrote:
> On Wed, Aug 07, 2013 at 01:12:29PM +0800, Wang Shilong wrote:
>> When disabling quota, we should clear out list 'dirty_qgroups',otherwise,
>> we will get oops if enabling quota again. Fix this by abstracting similar
>> code from del_qgroup_rb().
>>
>> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
>> Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>
>
> Can we get an xfstest for this, or at the very least a generic xfstest to
> exercise qgroups in general so I can be sure all these qgroup patches I take
> don't cause regressions? Thanks,
Yeah, we have a test suite ourself for btrfs qgroup, and i wil change it integrated into
xfstest later.
Thanks,
Wang
>
> Josef
>
next prev parent reply other threads:[~2013-08-09 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 5:12 [PATCH 1/3] Btrfs: fix oops when writing dirty qgroups to disk Wang Shilong
2013-08-07 5:12 ` [PATCH 2/3] Btrfs: move btrfs_free_qgroup_config() out of spin_lock and fix comments Wang Shilong
2013-08-09 9:42 ` Arne Jansen
2013-08-09 9:57 ` Wang Shilong
2013-08-07 5:12 ` [PATCH 3/3] Btrfs: remove reduplicate check when disabling quota Wang Shilong
2013-08-09 9:36 ` Arne Jansen
2013-08-07 5:16 ` [PATCH 1/3] Btrfs: fix oops when writing dirty qgroups to disk Wang Shilong
2013-08-08 13:20 ` Josef Bacik
2013-08-09 9:12 ` Wang Shilong [this message]
2013-08-09 9:30 ` Arne Jansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204B278.4010506@cn.fujitsu.com \
--to=wangsl.fnst@cn.fujitsu.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).