linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <Anand.Jain@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: btrfs_rm_device() should zero mirror SB as well
Date: Mon, 12 Aug 2013 10:39:15 +0800	[thread overview]
Message-ID: <52084AD3.5020400@oracle.com> (raw)
In-Reply-To: <5206BA38.20903@redhat.com>



Hi Eric,

>>>> btrfs fi show
>>>> Label: none  uuid: e7aae9f0-1aa8-41f5-8fb6-d4d8f80cdb2c
>>>>           Total devices 1 FS bytes used 28.00KiB
>>>>           devid    2 size 2.00GiB used 0.00 path /dev/sdc   <-- WRONG
>>>>           devid    1 size 2.00GiB used 20.00MiB path /dev/sdb
>>>
>>> Ok, now it's findable.  Isn't that exactly how this should behave?
>>> What is wrong about this?
>>
>>   Total devices is still 1.
>
> Hm, so it is.  But that inconsistency indicates a bug
> somewhere else, doesn't it?

  Nope. to undo dev-delete admin has to use dev-add.

  Here the idea is to release the disk nicely when
  we know we don't need it anymore.

Thanks, Anand


      reply	other threads:[~2013-08-12  2:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 17:29 [PATCH 1/2] btrfs: use BTRFS_SUPER_INFO_SIZE macro at btrfs_read_dev_super() Anand Jain
2013-07-25 17:29 ` [PATCH 2/2] btrfs: btrfs_rm_device() should zero mirror SB as well Anand Jain
2013-08-09 20:47   ` Eric Sandeen
2013-08-10  2:04     ` anand jain
2013-08-10 22:10       ` Eric Sandeen
2013-08-12  2:39         ` Anand Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52084AD3.5020400@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).