From: Anand Jain <Anand.Jain@oracle.com>
To: Chris Samuel <chris@csamuel.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: btrfs device stats /dev/mapper/ext4 SEGV
Date: Mon, 12 Aug 2013 10:55:44 +0800 [thread overview]
Message-ID: <52084EB0.9030606@oracle.com> (raw)
In-Reply-To: <1384122.xvVNAvLv2n@quad>
On 08/10/2013 09:56 PM, Chris Samuel wrote:
> On Sat, 10 Aug 2013 07:07:50 PM Russell Coker wrote:
>
>> I can repeatedly get the following SEGV from running "btrfs device stats" on
>> a device node for an Ext3/4 filesystem. This happens with the version of
>> the code downloaded from the above GIT repository as well as with an older
>> version. Obviously the command in question is not going to do anything
>> useful when run against a non-BTRFS filesystem, but it should do something
>> other than crash.
>
> The code calls btrfs_read_dev_super() on that filesystem, but it looks like the
> checks are failing to detect it as not btrfs. :-(
>
> I can reproduce the crash here too with ext3 and XFS filesystems.
There are quite a number of bug similar to this (that was
reported to the mainling list here, but hard to search now)
which is all triggered by using the backup super block invariably.
v6: access to backup superblock
http://permalink.gmane.org/gmane.comp.file-systems.btrfs/24746
provided fix. But it needs rebase, if you could
goback in git this patch might apply nicely for testing.
Thanks, Anand
prev parent reply other threads:[~2013-08-12 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 9:07 btrfs device stats /dev/mapper/ext4 SEGV Russell Coker
2013-08-10 13:56 ` Chris Samuel
2013-08-12 2:55 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52084EB0.9030606@oracle.com \
--to=anand.jain@oracle.com \
--cc=chris@csamuel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).