linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xfstests: make the scratch device for generic/256 slightly larger
@ 2013-07-02 19:17 Josef Bacik
  2013-07-24 23:07 ` Ben Myers
  2013-08-16 14:12 ` Rich Johnston
  0 siblings, 2 replies; 3+ messages in thread
From: Josef Bacik @ 2013-07-02 19:17 UTC (permalink / raw)
  To: linux-btrfs, xfs

This is similar to a previous fix I sent.  1 gig makes us do mixed file block
groups for btrfs, so these enospc tests will usually fail because we don't have
space for metadata, which is the case for this test.  So jack the size up to
1.5gig so that btrfs can do its normal thing and pass the test.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
 tests/generic/256 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/generic/256 b/tests/generic/256
index 4a53da8..cfe7237 100755
--- a/tests/generic/256
+++ b/tests/generic/256
@@ -165,7 +165,7 @@ _test_full_fs_punch()
 
 # Make a small file system to fill
 umount $SCRATCH_DEV &> /dev/null
-_scratch_mkfs_sized $(( 1024 * 1024 * 1024 )) &> /dev/null
+_scratch_mkfs_sized $(( 1536 * 1024 * 1024 )) &> /dev/null
 _scratch_mount
 # Test must be able to write files with non-root permissions
 chmod 777 $SCRATCH_MNT
-- 
1.7.7.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: make the scratch device for generic/256 slightly larger
  2013-07-02 19:17 [PATCH] xfstests: make the scratch device for generic/256 slightly larger Josef Bacik
@ 2013-07-24 23:07 ` Ben Myers
  2013-08-16 14:12 ` Rich Johnston
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Myers @ 2013-07-24 23:07 UTC (permalink / raw)
  To: Josef Bacik; +Cc: linux-btrfs, xfs

On Tue, Jul 02, 2013 at 03:17:18PM -0400, Josef Bacik wrote:
> This is similar to a previous fix I sent.  1 gig makes us do mixed file block
> groups for btrfs, so these enospc tests will usually fail because we don't have
> space for metadata, which is the case for this test.  So jack the size up to
> 1.5gig so that btrfs can do its normal thing and pass the test.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Looks fine to me.  

Reviewed-by: Ben Myers <bpm@sgi.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: xfstests: make the scratch device for generic/256 slightly larger
  2013-07-02 19:17 [PATCH] xfstests: make the scratch device for generic/256 slightly larger Josef Bacik
  2013-07-24 23:07 ` Ben Myers
@ 2013-08-16 14:12 ` Rich Johnston
  1 sibling, 0 replies; 3+ messages in thread
From: Rich Johnston @ 2013-08-16 14:12 UTC (permalink / raw)
  To: Josef Bacik; +Cc: linux-btrfs, xfs

Hey Josef,

Sorry this took so long to commit, I did not see it had been reviewed.

Thanks again for the patch
--Rich

commit 617491caf44d5e93006d774da95f532e9d7de4c4
Author: Josef Bacik <jbacik@fusionio.com>
Date:   Tue Jul 2 19:17:18 2013 +0000


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-08-16 14:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-02 19:17 [PATCH] xfstests: make the scratch device for generic/256 slightly larger Josef Bacik
2013-07-24 23:07 ` Ben Myers
2013-08-16 14:12 ` Rich Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).