From: Anand Jain <Anand.Jain@oracle.com>
To: Zach Brown <zab@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs-progs: move out print in cmd_df to another function
Date: Tue, 20 Aug 2013 14:17:43 +0800 [thread overview]
Message-ID: <52130A07.1000001@oracle.com> (raw)
In-Reply-To: <20130819192052.GA1829@lenny.home.zabbo.net>
> This seems to be a whole lot of code for a simple iterating printf:
>
> struct space_type_thingy_whatver *sp = sargs->spaces;
>
> for (i = 0; i < sargs->total_spaces; i++, sp++) {
> printf("%s, %s: total=%s, used=%s\n",
> group_type_str(sp->flags),
> group_profile_str(sp->flags),
> pretty_size(sp->total_bytes),
> pretty_size(sp->used_bytes));
> }
>
> - z
Thanks for the review. Sent v3 for this.
Anand
next prev parent reply other threads:[~2013-08-20 6:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 12:48 [PATCH 0/3] fi show, dev scan and lblkid Anand Jain
2013-08-16 12:48 ` [PATCH 1/3] btrfs-progs: move out print in cmd_df to another function Anand Jain
2013-08-19 19:20 ` Zach Brown
2013-08-20 6:17 ` Anand Jain [this message]
2013-08-20 6:16 ` [PATCH] btrfs-progs: v3, " Anand Jain
2013-08-30 2:01 ` [PATCH 1/3] btrfs-progs: " Wang Shilong
2013-08-30 2:28 ` Anand Jain
2013-08-16 12:48 ` [PATCH 2/3] btrfs-progs: read from the kernel when disk is mounted Anand Jain
2013-08-30 2:07 ` Wang Shilong
2013-08-16 12:48 ` [PATCH 3/3] btrfs-progs: use lblkid to scan and filesystem show improvements Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52130A07.1000001@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).