From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks
Date: Sun, 15 Sep 2013 12:30:35 +0800 [thread overview]
Message-ID: <523537EB.5020604@oracle.com> (raw)
In-Reply-To: <20130913172520.GP6810@twin.jikos.cz>
>> ---------------
>> btrfs fi show
>> Label: none uuid: a2446ecf-68c5-4815-8b63-099d10fc373c mounted: /btrfs
>> Group profile: metadata: single metadata: DUP data: single
>
> I didn't notice that before, this does not bring much information
> without the numbers as 'fi df' does. Please drop the printf lines
Thanks for the review.
IMO group profile is useful info to have it at both the places.
end user using this new btrfs fi show would surely notice that it
will reduce other commands normally used following the current
btrfs fi show command. (like mount and btrfs fi df). of course
user should use fi df to know detailed info about the sizes.
-------
btrfs fi show
Label: none uuid: 2c654c36-ba53-4cc8-9c95-f0bee667b9a6 mounted: /btrfs
Group profile: Data+Metadata: single
Total devices 2 FS bytes used 3.17MiB
devid 1 size 1.98GiB used 12.00MiB path /dev/mapper/mpatha
devid 2 size 2.00GiB used 416.00MiB path /dev/mapper/mpathb
-------
Thanks, Anand
next prev parent reply other threads:[~2013-09-15 4:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 11:32 [PATCH 0/2 v3] fi show, dev scan and lblkid Anand Jain
2013-09-13 11:32 ` [PATCH 1/2] btrfs-progs: move out print in cmd_df to another function Anand Jain
2013-09-13 17:01 ` David Sterba
2013-09-13 11:32 ` [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks Anand Jain
2013-09-13 17:25 ` David Sterba
2013-09-15 4:30 ` Anand Jain [this message]
2013-09-16 15:42 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2013-08-30 8:35 [PATCH 0/2] v2, fi show, dev scan and lblkid Anand Jain
2013-08-30 8:35 ` [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523537EB.5020604@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).