* [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
@ 2013-09-18 1:11 rongqing.li
2013-09-18 1:51 ` Eric Sandeen
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: rongqing.li @ 2013-09-18 1:11 UTC (permalink / raw)
To: linux-btrfs; +Cc: sandeen
From: Roy Li <rongqing.li@windriver.com>
The dependencies of "all: version.h" or other similar ones can not
fix the parallel build failure, only reduce the times; In fact,
many *.o files require version.h file.
#grep '#include "version.h"' ./ -r
./btrfs-corrupt-block.c:#include "version.h"
./btrfs.c:#include "version.h"
./btrfs-image.c:#include "version.h"
./cmds-filesystem.c:#include "version.h"
./btrfs-show-super.c:#include "version.h"
./btrfs-select-super.c:#include "version.h"
./cmds-restore.c:#include "version.h"
./btrfs-find-root.c:#include "version.h"
./mkfs.c:#include "version.h"
./btrfs-zero-log.c:#include "version.h"
./btrfs-defrag.c:#include "version.h"
./cmds-chunk.c:#include "version.h"
./btrfstune.c:#include "version.h"
./btrfs-calc-size.c:#include "version.h"
./btrfs-map-logical.c:#include "version.h"
./cmds-check.c:#include "version.h"
./btrfs-debug-tree.c:#include "version.h"
Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
Sorry, The patch [btrfs-progs: fix parallel build] sent by me on Sep 3
can not fix the build failure, when build enough times on a 16 core cpu,
the build failure happens again, so I refix it again.
Makefile | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index c43cb68..a7c259c 100644
--- a/Makefile
+++ b/Makefile
@@ -81,6 +81,12 @@ endif
@echo " [CC] $@"
$(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
+btrfs-corrupt-block.o btrfs.o btrfs-image.o cmds-filesystem.o:version.h
+btrfs-show-super.o btrfs-select-super.o cmds-restore.o:version.h
+btrfs-find-root.o mkfs.o btrfs-zero-log.o btrfs-defrag.o cmds-chunk.o:version.h
+btrfstune.o btrfs-calc-size.o btrfs-map-logical.o cmds-check.o:version.h
+btrfs-debug-tree.o:version.h
+
%.static.o: %.c
@echo " [CC] $@"
$(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
2013-09-18 1:11 [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue rongqing.li
@ 2013-09-18 1:51 ` Eric Sandeen
2013-09-18 1:55 ` Rongqing Li
2013-09-23 7:17 ` Rongqing Li
2013-09-18 1:56 ` [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds Eric Sandeen
2013-09-18 14:51 ` [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue David Sterba
2 siblings, 2 replies; 10+ messages in thread
From: Eric Sandeen @ 2013-09-18 1:51 UTC (permalink / raw)
To: rongqing.li; +Cc: linux-btrfs
On 9/17/13 8:11 PM, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> The dependencies of "all: version.h" or other similar ones can not
> fix the parallel build failure, only reduce the times; In fact,
> many *.o files require version.h file.
>
> #grep '#include "version.h"' ./ -r
> ./btrfs-corrupt-block.c:#include "version.h"
> ./btrfs.c:#include "version.h"
> ./btrfs-image.c:#include "version.h"
> ./cmds-filesystem.c:#include "version.h"
> ./btrfs-show-super.c:#include "version.h"
> ./btrfs-select-super.c:#include "version.h"
> ./cmds-restore.c:#include "version.h"
> ./btrfs-find-root.c:#include "version.h"
> ./mkfs.c:#include "version.h"
> ./btrfs-zero-log.c:#include "version.h"
> ./btrfs-defrag.c:#include "version.h"
> ./cmds-chunk.c:#include "version.h"
> ./btrfstune.c:#include "version.h"
> ./btrfs-calc-size.c:#include "version.h"
> ./btrfs-map-logical.c:#include "version.h"
> ./cmds-check.c:#include "version.h"
> ./btrfs-debug-tree.c:#include "version.h"
>
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
> Sorry, The patch [btrfs-progs: fix parallel build] sent by me on Sep 3
> can not fix the build failure, when build enough times on a 16 core cpu,
> the build failure happens again, so I refix it again.
>
>
> Makefile | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c43cb68..a7c259c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -81,6 +81,12 @@ endif
> @echo " [CC] $@"
> $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
>
> +btrfs-corrupt-block.o btrfs.o btrfs-image.o cmds-filesystem.o:version.h
> +btrfs-show-super.o btrfs-select-super.o cmds-restore.o:version.h
> +btrfs-find-root.o mkfs.o btrfs-zero-log.o btrfs-defrag.o cmds-chunk.o:version.h
> +btrfstune.o btrfs-calc-size.o btrfs-map-logical.o cmds-check.o:version.h
> +btrfs-debug-tree.o:version.h
> +
> %.static.o: %.c
> @echo " [CC] $@"
> $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>
I think this can be done more cleanly, I'll send a patch.
-Eric
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
2013-09-18 1:51 ` Eric Sandeen
@ 2013-09-18 1:55 ` Rongqing Li
2013-09-23 7:17 ` Rongqing Li
1 sibling, 0 replies; 10+ messages in thread
From: Rongqing Li @ 2013-09-18 1:55 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-btrfs
On 09/18/2013 09:51 AM, Eric Sandeen wrote:
>> @echo " [CC] $@"
>> > $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>> >
> I think this can be done more cleanly, I'll send a patch.
>
> -Eric
>
>
Thanks, expect your patch
-Roy
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
2013-09-18 1:51 ` Eric Sandeen
2013-09-18 1:55 ` Rongqing Li
@ 2013-09-23 7:17 ` Rongqing Li
1 sibling, 0 replies; 10+ messages in thread
From: Rongqing Li @ 2013-09-23 7:17 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-btrfs
On 09/18/2013 09:51 AM, Eric Sandeen wrote:
> On 9/17/13 8:11 PM, rongqing.li@windriver.com wrote:
>> From: Roy Li <rongqing.li@windriver.com>
>>
>> The dependencies of "all: version.h" or other similar ones can not
>> fix the parallel build failure, only reduce the times; In fact,
>> many *.o files require version.h file.
>>
>> #grep '#include "version.h"' ./ -r
>> ./btrfs-corrupt-block.c:#include "version.h"
>> ./btrfs.c:#include "version.h"
>> ./btrfs-image.c:#include "version.h"
>> ./cmds-filesystem.c:#include "version.h"
>> ./btrfs-show-super.c:#include "version.h"
>> ./btrfs-select-super.c:#include "version.h"
>> ./cmds-restore.c:#include "version.h"
>> ./btrfs-find-root.c:#include "version.h"
>> ./mkfs.c:#include "version.h"
>> ./btrfs-zero-log.c:#include "version.h"
>> ./btrfs-defrag.c:#include "version.h"
>> ./cmds-chunk.c:#include "version.h"
>> ./btrfstune.c:#include "version.h"
>> ./btrfs-calc-size.c:#include "version.h"
>> ./btrfs-map-logical.c:#include "version.h"
>> ./cmds-check.c:#include "version.h"
>> ./btrfs-debug-tree.c:#include "version.h"
>>
>> Signed-off-by: Roy Li <rongqing.li@windriver.com>
>> ---
>> Sorry, The patch [btrfs-progs: fix parallel build] sent by me on Sep 3
>> can not fix the build failure, when build enough times on a 16 core cpu,
>> the build failure happens again, so I refix it again.
>>
>>
>> Makefile | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index c43cb68..a7c259c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -81,6 +81,12 @@ endif
>> @echo " [CC] $@"
>> $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
>>
>> +btrfs-corrupt-block.o btrfs.o btrfs-image.o cmds-filesystem.o:version.h
>> +btrfs-show-super.o btrfs-select-super.o cmds-restore.o:version.h
>> +btrfs-find-root.o mkfs.o btrfs-zero-log.o btrfs-defrag.o cmds-chunk.o:version.h
>> +btrfstune.o btrfs-calc-size.o btrfs-map-logical.o cmds-check.o:version.h
>> +btrfs-debug-tree.o:version.h
>> +
>> %.static.o: %.c
>> @echo " [CC] $@"
>> $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>>
>
> I think this can be done more cleanly, I'll send a patch.
>
> -Eric
>
>
If this one is not cleanly, how is the below one
From a56ac083a789605904507b602d9ebf196ae6746d Mon Sep 17 00:00:00 2001
From: Roy Li <rongqing.li@windriver.com>
Date: Mon, 23 Sep 2013 09:53:30 +0800
Subject: [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel
build issue
The dependencies of "all: version.h" or other similar ones can not
fix the parallel build failure, only reduce the times; In fact,
many *.o files require version.h file.
#grep '#include "version.h"' ./ -r
./btrfs-corrupt-block.c:#include "version.h"
./btrfs.c:#include "version.h"
./btrfs-image.c:#include "version.h"
./cmds-filesystem.c:#include "version.h"
./btrfs-show-super.c:#include "version.h"
./btrfs-select-super.c:#include "version.h"
./cmds-restore.c:#include "version.h"
./btrfs-find-root.c:#include "version.h"
./mkfs.c:#include "version.h"
./btrfs-zero-log.c:#include "version.h"
./btrfs-defrag.c:#include "version.h"
./cmds-chunk.c:#include "version.h"
./btrfstune.c:#include "version.h"
./btrfs-calc-size.c:#include "version.h"
./btrfs-map-logical.c:#include "version.h"
./cmds-check.c:#include "version.h"
./btrfs-debug-tree.c:#include "version.h"
Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index c43cb68..901ffa2 100644
--- a/Makefile
+++ b/Makefile
@@ -81,6 +81,8 @@ endif
@echo " [CC] $@"
$(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
+%.o: version.h
+
%.static.o: %.c
@echo " [CC] $@"
$(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
--
1.7.10.4
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds
2013-09-18 1:11 [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue rongqing.li
2013-09-18 1:51 ` Eric Sandeen
@ 2013-09-18 1:56 ` Eric Sandeen
2013-09-18 2:26 ` Eric Sandeen
2013-09-18 14:51 ` [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue David Sterba
2 siblings, 1 reply; 10+ messages in thread
From: Eric Sandeen @ 2013-09-18 1:56 UTC (permalink / raw)
To: rongqing.li; +Cc: linux-btrfs
Change the suffix rule to ensure that version.h is
built before we try to create any .o file.
Reported-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I dunno, does this work? My gnu make is rusty.
diff --git a/Makefile b/Makefile
index 3d715d8..d25054f 100644
--- a/Makefile
+++ b/Makefile
@@ -107,13 +107,13 @@ endif
%.o.d: %.c
$(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
-.c.o:
+%.o: %.c version.h
@$(check_echo) " [SP] $<"
$(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $<
@echo " [CC] $@"
$(Q)$(CC) $(AM_CFLAGS) $(CFLAGS) -c $<
-%.static.o: %.c
+%.static.o: %.c version.h
@echo " [CC] $@"
$(Q)$(CC) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds
2013-09-18 1:56 ` [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds Eric Sandeen
@ 2013-09-18 2:26 ` Eric Sandeen
2013-09-18 6:39 ` Rongqing Li
0 siblings, 1 reply; 10+ messages in thread
From: Eric Sandeen @ 2013-09-18 2:26 UTC (permalink / raw)
To: rongqing.li; +Cc: linux-btrfs
On 9/17/13 8:56 PM, Eric Sandeen wrote:
> Change the suffix rule to ensure that version.h is
> built before we try to create any .o file.
>
> Reported-by: Roy Li <rongqing.li@windriver.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> I dunno, does this work? My gnu make is rusty.
I'm actually confused by what the makefile is doing with the
dependency generation, maybe my patch isn't right.
this:
%.o.d: %.c
$(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
completely confuses me :)
-Eric
> diff --git a/Makefile b/Makefile
> index 3d715d8..d25054f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -107,13 +107,13 @@ endif
> %.o.d: %.c
> $(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
>
> -.c.o:
> +%.o: %.c version.h
> @$(check_echo) " [SP] $<"
> $(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $<
> @echo " [CC] $@"
> $(Q)$(CC) $(AM_CFLAGS) $(CFLAGS) -c $<
>
> -%.static.o: %.c
> +%.static.o: %.c version.h
> @echo " [CC] $@"
> $(Q)$(CC) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds
2013-09-18 2:26 ` Eric Sandeen
@ 2013-09-18 6:39 ` Rongqing Li
0 siblings, 0 replies; 10+ messages in thread
From: Rongqing Li @ 2013-09-18 6:39 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-btrfs
On 09/18/2013 10:26 AM, Eric Sandeen wrote:
> On 9/17/13 8:56 PM, Eric Sandeen wrote:
>> Change the suffix rule to ensure that version.h is
>> built before we try to create any .o file.
>>
>> Reported-by: Roy Li <rongqing.li@windriver.com>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> I dunno, does this work? My gnu make is rusty.
>
> I'm actually confused by what the makefile is doing with the
> dependency generation, maybe my patch isn't right.
>
> this:
>
> %.o.d: %.c
> $(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
>
> completely confuses me :)
>
> -Eric
It lead to the below building error:
n file included from ctree.c:18:0:
| ctree.h:30:24: fatal error: btrfs/list.h: No such file or directory
| #include <btrfs/list.h>
| ^
| compilation terminated.
| In file included from extent-tree.c:22:0:
| radix-tree.h:43:30: fatal error: btrfs/kerncompat.h: No such file or
directory
| #include <btrfs/kerncompat.h>
| ^
| compilation terminated.
| In file included from disk-io.c:29:0:
| radix-tree.h:43:30: fatal error: btrfs/kerncompat.h: No such file or
directory
| #include <btrfs/kerncompat.h>
| ^
| compilation terminated.
| In file included from radix-tree.c:40:0:
| radix-tree.h:43:30: fatal error: btrfs/kerncompat.h: No such file or
directory
| #include <btrfs/kerncompat.h>
| ^
| compilation terminated.
| In file included from root-tree.c:19:0:
| ctree.h:30:24: fatal error: btrfs/list.h: No such file or directory
| #include <btrfs/list.h>
| ^
| compilation terminated.
-Roy
>
>> diff --git a/Makefile b/Makefile
>> index 3d715d8..d25054f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -107,13 +107,13 @@ endif
>> %.o.d: %.c
>> $(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
>>
>> -.c.o:
>> +%.o: %.c version.h
>> @$(check_echo) " [SP] $<"
>> $(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $<
>> @echo " [CC] $@"
>> $(Q)$(CC) $(AM_CFLAGS) $(CFLAGS) -c $<
>>
>> -%.static.o: %.c
>> +%.static.o: %.c version.h
>> @echo " [CC] $@"
>> $(Q)$(CC) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
2013-09-18 1:11 [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue rongqing.li
2013-09-18 1:51 ` Eric Sandeen
2013-09-18 1:56 ` [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds Eric Sandeen
@ 2013-09-18 14:51 ` David Sterba
2013-09-22 1:06 ` Rongqing Li
2 siblings, 1 reply; 10+ messages in thread
From: David Sterba @ 2013-09-18 14:51 UTC (permalink / raw)
To: rongqing.li; +Cc: linux-btrfs, sandeen
On Wed, Sep 18, 2013 at 09:11:01AM +0800, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> The dependencies of "all: version.h" or other similar ones can not
> fix the parallel build failure, only reduce the times; In fact,
> many *.o files require version.h file.
>
> #grep '#include "version.h"' ./ -r
> ./btrfs-corrupt-block.c:#include "version.h"
> ./btrfs.c:#include "version.h"
> ./btrfs-image.c:#include "version.h"
> ./cmds-filesystem.c:#include "version.h"
> ./btrfs-show-super.c:#include "version.h"
> ./btrfs-select-super.c:#include "version.h"
> ./cmds-restore.c:#include "version.h"
> ./btrfs-find-root.c:#include "version.h"
> ./mkfs.c:#include "version.h"
> ./btrfs-zero-log.c:#include "version.h"
> ./btrfs-defrag.c:#include "version.h"
> ./cmds-chunk.c:#include "version.h"
> ./btrfstune.c:#include "version.h"
> ./btrfs-calc-size.c:#include "version.h"
> ./btrfs-map-logical.c:#include "version.h"
> ./cmds-check.c:#include "version.h"
> ./btrfs-debug-tree.c:#include "version.h"
>
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
> Sorry, The patch [btrfs-progs: fix parallel build] sent by me on Sep 3
> can not fix the build failure, when build enough times on a 16 core cpu,
> the build failure happens again, so I refix it again.
I'm running make -j all the time but haven't seen the build fail due to
missing version.h for a long time. With this patch or the previous one
or with Eric's, all fine. The generated dependency files contain
version.h so make has complete information how to order the rules.
The dependency files are generated by an implicit rule .c -> .o.d, so
there should be no problem for any of the files listed above.
If you think the patch "btrfs-progs: fix parallel build" does not help
much I'll drop it.
david
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
2013-09-18 14:51 ` [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue David Sterba
@ 2013-09-22 1:06 ` Rongqing Li
2013-09-23 12:26 ` David Sterba
0 siblings, 1 reply; 10+ messages in thread
From: Rongqing Li @ 2013-09-22 1:06 UTC (permalink / raw)
To: dsterba, linux-btrfs, sandeen
On 09/18/2013 10:51 PM, David Sterba wrote:
> On Wed, Sep 18, 2013 at 09:11:01AM +0800, rongqing.li@windriver.com wrote:
>> From: Roy Li <rongqing.li@windriver.com>
>>
>> The dependencies of "all: version.h" or other similar ones can not
>> fix the parallel build failure, only reduce the times; In fact,
>> many *.o files require version.h file.
>>
>> #grep '#include "version.h"' ./ -r
>> ./btrfs-corrupt-block.c:#include "version.h"
>> ./btrfs.c:#include "version.h"
>> ./btrfs-image.c:#include "version.h"
>> ./cmds-filesystem.c:#include "version.h"
>> ./btrfs-show-super.c:#include "version.h"
>> ./btrfs-select-super.c:#include "version.h"
>> ./cmds-restore.c:#include "version.h"
>> ./btrfs-find-root.c:#include "version.h"
>> ./mkfs.c:#include "version.h"
>> ./btrfs-zero-log.c:#include "version.h"
>> ./btrfs-defrag.c:#include "version.h"
>> ./cmds-chunk.c:#include "version.h"
>> ./btrfstune.c:#include "version.h"
>> ./btrfs-calc-size.c:#include "version.h"
>> ./btrfs-map-logical.c:#include "version.h"
>> ./cmds-check.c:#include "version.h"
>> ./btrfs-debug-tree.c:#include "version.h"
>>
>> Signed-off-by: Roy Li <rongqing.li@windriver.com>
>> ---
>> Sorry, The patch [btrfs-progs: fix parallel build] sent by me on Sep 3
>> can not fix the build failure, when build enough times on a 16 core cpu,
>> the build failure happens again, so I refix it again.
>
> I'm running make -j all the time but haven't seen the build fail due to
> missing version.h for a long time. With this patch or the previous one
> or with Eric's, all fine. The generated dependency files contain
> version.h so make has complete information how to order the rules.
>
I want to know how many cores your cpu has? I can not reproduce it on
my 2 cores cpu, but it always happens when run on a server which is
a 16 cores cpu and "make -j20"
> The dependency files are generated by an implicit rule .c -> .o.d, so
> there should be no problem for any of the files listed above.
>
Do you means the below:
.c.o:
$(Q)$(check) $<
@echo " [CC] $@"
$(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
-Roy
> If you think the patch "btrfs-progs: fix parallel build" does not help
> much I'll drop it.
>
>
> david
>
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue
2013-09-22 1:06 ` Rongqing Li
@ 2013-09-23 12:26 ` David Sterba
0 siblings, 0 replies; 10+ messages in thread
From: David Sterba @ 2013-09-23 12:26 UTC (permalink / raw)
To: Rongqing Li; +Cc: linux-btrfs, sandeen
On Sun, Sep 22, 2013 at 09:06:39AM +0800, Rongqing Li wrote:
> I want to know how many cores your cpu has? I can not reproduce it on
> my 2 cores cpu, but it always happens when run on a server which is
> a 16 cores cpu and "make -j20"
Depends on what you call a core, I've tested this on a box with 8 cpu
cores and 64 logical cpus. I can clearly see that the build is stalled
for a few moments at '[SH] version.h' before it proceeds to '[CC] ...'.
> >The dependency files are generated by an implicit rule .c -> .o.d, so
> >there should be no problem for any of the files listed above.
>
> Do you means the below:
>
> .c.o:
> $(Q)$(check) $<
> @echo " [CC] $@"
> $(Q)$(CC) $(DEPFLAGS) $(AM_CFLAGS) $(CFLAGS) -c $<
Rather
%.o.d: %.c
$(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
the .o.d files are included at the end of Makefile, I'm not completely
sure that they get included before the .c.o rule is processed. That way
the .o.d files would be empty and the dependency on version.h missing.
david
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-09-23 12:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 1:11 [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue rongqing.li
2013-09-18 1:51 ` Eric Sandeen
2013-09-18 1:55 ` Rongqing Li
2013-09-23 7:17 ` Rongqing Li
2013-09-18 1:56 ` [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds Eric Sandeen
2013-09-18 2:26 ` Eric Sandeen
2013-09-18 6:39 ` Rongqing Li
2013-09-18 14:51 ` [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue David Sterba
2013-09-22 1:06 ` Rongqing Li
2013-09-23 12:26 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).