From: Rongqing Li <rongqing.li@windriver.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds
Date: Wed, 18 Sep 2013 14:39:28 +0800 [thread overview]
Message-ID: <52394AA0.9040000@windriver.com> (raw)
In-Reply-To: <52390F72.7030908@redhat.com>
On 09/18/2013 10:26 AM, Eric Sandeen wrote:
> On 9/17/13 8:56 PM, Eric Sandeen wrote:
>> Change the suffix rule to ensure that version.h is
>> built before we try to create any .o file.
>>
>> Reported-by: Roy Li <rongqing.li@windriver.com>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> I dunno, does this work? My gnu make is rusty.
>
> I'm actually confused by what the makefile is doing with the
> dependency generation, maybe my patch isn't right.
>
> this:
>
> %.o.d: %.c
> $(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
>
> completely confuses me :)
>
> -Eric
It lead to the below building error:
n file included from ctree.c:18:0:
| ctree.h:30:24: fatal error: btrfs/list.h: No such file or directory
| #include <btrfs/list.h>
| ^
| compilation terminated.
| In file included from extent-tree.c:22:0:
| radix-tree.h:43:30: fatal error: btrfs/kerncompat.h: No such file or
directory
| #include <btrfs/kerncompat.h>
| ^
| compilation terminated.
| In file included from disk-io.c:29:0:
| radix-tree.h:43:30: fatal error: btrfs/kerncompat.h: No such file or
directory
| #include <btrfs/kerncompat.h>
| ^
| compilation terminated.
| In file included from radix-tree.c:40:0:
| radix-tree.h:43:30: fatal error: btrfs/kerncompat.h: No such file or
directory
| #include <btrfs/kerncompat.h>
| ^
| compilation terminated.
| In file included from root-tree.c:19:0:
| ctree.h:30:24: fatal error: btrfs/list.h: No such file or directory
| #include <btrfs/list.h>
| ^
| compilation terminated.
-Roy
>
>> diff --git a/Makefile b/Makefile
>> index 3d715d8..d25054f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -107,13 +107,13 @@ endif
>> %.o.d: %.c
>> $(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
>>
>> -.c.o:
>> +%.o: %.c version.h
>> @$(check_echo) " [SP] $<"
>> $(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $<
>> @echo " [CC] $@"
>> $(Q)$(CC) $(AM_CFLAGS) $(CFLAGS) -c $<
>>
>> -%.static.o: %.c
>> +%.static.o: %.c version.h
>> @echo " [CC] $@"
>> $(Q)$(CC) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
--
Best Reagrds,
Roy | RongQing Li
next prev parent reply other threads:[~2013-09-18 6:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 1:11 [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue rongqing.li
2013-09-18 1:51 ` Eric Sandeen
2013-09-18 1:55 ` Rongqing Li
2013-09-23 7:17 ` Rongqing Li
2013-09-18 1:56 ` [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds Eric Sandeen
2013-09-18 2:26 ` Eric Sandeen
2013-09-18 6:39 ` Rongqing Li [this message]
2013-09-18 14:51 ` [PATCH] btrfs-progs: Add dependencies explicitly to fix a parallel build issue David Sterba
2013-09-22 1:06 ` Rongqing Li
2013-09-23 12:26 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52394AA0.9040000@windriver.com \
--to=rongqing.li@windriver.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).