From: Bob Marley <bobmarley@shiftmail.org>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: Wang Shilong <wangshilong1991@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix race condition between writting and scrubing supers
Date: Tue, 22 Oct 2013 18:55:59 +0200 [thread overview]
Message-ID: <5266AE1F.6030304@shiftmail.org> (raw)
In-Reply-To: <52663960.4060905@giantdisaster.de>
On 22/10/2013 10:37, Stefan Behrens wrote:
> I don't believe that this issue can ever happen. I don't believe that
> somewhere on the path to the flash memory, to the magnetic disc or to
> the drive's cache memory, someone interrupts a 4KB write in the middle
> of operation to read from this 4KB area. This is not an issue IMHO.
I think I have read that unfortunately it can happen.
SAS and SATA specs for disks do not mandate that if a write is in-flight
but still not completed, reads from the same sector should return the
value it is being written; they can return the old value.
I also think that Linux does not check either.
Much worse, I think I have even read that two simultaneous in-flight
writes to the same sector can be completed in any order by the disk, and
since the write which wins is the latter being completed, this results
in an indeterminate value persisting on that sector at the end. One
needs to synchronize cache between the two writes to guarantee the
outcome. Way worse is when the drives also cheat on synchronize cache,
and that one is impossible to fix I believe.
next prev parent reply other threads:[~2013-10-22 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 4:17 [PATCH] Btrfs: fix race condition between writting and scrubing supers Wang Shilong
2013-10-19 8:50 ` Stefan Behrens
2013-10-19 10:32 ` Shilong Wang
2013-10-19 14:03 ` Stefan Behrens
2013-10-19 14:34 ` Wang Shilong
2013-10-20 4:03 ` Wang Shilong
2013-10-22 8:37 ` Stefan Behrens
2013-10-22 16:55 ` Bob Marley [this message]
2013-10-23 17:21 ` Stefan Behrens
2013-10-24 10:08 ` Chris Mason
2013-10-24 10:42 ` Miao Xie
2013-10-24 11:32 ` Wang Shilong
2013-10-25 2:14 ` Miao Xie
2013-10-20 7:28 ` Bob Marley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5266AE1F.6030304@shiftmail.org \
--to=bobmarley@shiftmail.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).