From: Jeff Mahoney <jeffm@suse.com>
To: Zach Brown <zab@redhat.com>
Cc: linux-btrfs@vger.kernel.org, Josef Bacik <jbacik@fusionio.com>
Subject: Re: [PATCH 01/13] btrfs: add ioctls to query/change feature bits online
Date: Sun, 03 Nov 2013 17:02:57 -0500 [thread overview]
Message-ID: <5276C811.9040201@suse.com> (raw)
In-Reply-To: <20131101205659.GQ19383@lenny.home.zabbo.net>
[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]
On 11/1/13, 4:56 PM, Zach Brown wrote:
>> +static int btrfs_ioctl_get_supported_features(struct file *file,
>> + void __user *arg)
>> +{
>> + struct btrfs_ioctl_feature_flags features[3];
>> +
>> + features[0].compat_flags = BTRFS_FEATURE_COMPAT_SUPP;
>> + features[0].compat_ro_flags = BTRFS_FEATURE_COMPAT_RO_SUPP;
>> + features[0].incompat_flags = BTRFS_FEATURE_INCOMPAT_SUPP;
>> +
>> + features[1].compat_flags = BTRFS_FEATURE_COMPAT_SAFE_SET;
>> + features[1].compat_ro_flags = BTRFS_FEATURE_COMPAT_RO_SAFE_SET;
>> + features[1].incompat_flags = BTRFS_FEATURE_INCOMPAT_SAFE_SET;
>> +
>> + features[2].compat_flags = BTRFS_FEATURE_COMPAT_SAFE_CLEAR;
>> + features[2].compat_ro_flags = BTRFS_FEATURE_COMPAT_RO_SAFE_CLEAR;
>> + features[2].incompat_flags = BTRFS_FEATURE_INCOMPAT_SAFE_CLEAR;
>> +
>> + if (copy_to_user(arg, &features, sizeof(features)))
>> + return -EFAULT;
>
> If these are all constants shouldn't that just copy out of a static
> built flags array?
Works for me. Change added.
-Jeff
> #define cpp4ever(suff) \
> BTRFS_FEATURE_COMPAT_#suff, BTRFS_FEATURE_COMPAT_RO_#suff, \
> BTRFS_FEATURE_INCOMPAT_#suff
>
> static struct btrfs_ioctl_feature_flags features[3] = {
> { cpp4ever(SUPP) }, { cpp4ever(SAFE_SET) },
> { cpp4ever(SAFE_CLEAR) },
> };
>
> if (copy_to_user(arg, &features, sizeof(features)))
> return -EFAULT;
>
> ?
>
> - z
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Jeff Mahoney
SUSE Labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 841 bytes --]
next prev parent reply other threads:[~2013-11-03 22:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 17:06 [PATCH 00/13] [PATCH 00/13] sysfs publishing patchset (v2) Jeff Mahoney
2013-11-01 17:06 ` [PATCH 01/13] btrfs: add ioctls to query/change feature bits online Jeff Mahoney
2013-11-01 20:56 ` Zach Brown
2013-11-03 22:02 ` Jeff Mahoney [this message]
2013-11-01 17:06 ` [PATCH 02/13] kobject: export kobj_sysfs_ops Jeff Mahoney
2013-11-01 17:06 ` [PATCH 03/13] btrfs: publish supported featured in sysfs Jeff Mahoney
2013-11-01 17:06 ` [PATCH 04/13] btrfs: publish per-super attributes " Jeff Mahoney
2013-11-01 17:06 ` [PATCH 05/13] btrfs: publish per-super features " Jeff Mahoney
2013-11-01 17:07 ` [PATCH 06/13] btrfs: publish unknown feature bits " Jeff Mahoney
2013-11-01 17:07 ` [PATCH 07/13] btrfs: add ability to change features via sysfs Jeff Mahoney
2013-11-01 17:07 ` [PATCH 08/13] btrfs: use feature attribute names to print better error messages Jeff Mahoney
2013-11-01 17:07 ` [PATCH 09/13] btrfs: add ioctl to export size of global metadata reservation Jeff Mahoney
2013-11-01 17:07 ` [PATCH 10/13] btrfs: publish allocation data in sysfs Jeff Mahoney
2013-11-01 17:07 ` [PATCH 11/13] btrfs: publish device membership " Jeff Mahoney
2013-11-01 17:07 ` [PATCH 12/13] btrfs: publish fs label " Jeff Mahoney
2013-11-01 17:07 ` [PATCH 13/13] btrfs: add tracing for failed reservations Jeff Mahoney
2013-11-06 17:02 ` [PATCH 00/13] [PATCH 00/13] sysfs publishing patchset (v2) David Sterba
2013-11-06 17:08 ` Jeff Mahoney
2013-11-06 17:09 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2013-11-15 20:33 [PATCH 00/13] sysfs publishing patchset (v3) Jeff Mahoney
2013-11-15 20:33 ` [PATCH 01/13] btrfs: add ioctls to query/change feature bits online Jeff Mahoney
2013-10-21 21:19 [patch 00/13] sysfs publishing patchset Jeff Mahoney
2013-10-21 21:19 ` [patch 01/13] btrfs: add ioctls to query/change feature bits online Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5276C811.9040201@suse.com \
--to=jeffm@suse.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).