From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:37759 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733Ab3KGC44 (ORCPT ); Wed, 6 Nov 2013 21:56:56 -0500 Message-ID: <527B0379.3040608@oracle.com> Date: Thu, 07 Nov 2013 11:05:29 +0800 From: Anand Jain MIME-Version: 1.0 To: Eric Sandeen CC: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 05/16] btrfs-progs: don't leak fd in test_dev_for_mkfs() error paths References: <1383779755-18228-1-git-send-email-sandeen@redhat.com> <1383779755-18228-6-git-send-email-sandeen@redhat.com> In-Reply-To: <1383779755-18228-6-git-send-email-sandeen@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: Reviewed-by: Anand Jain On 11/07/2013 07:15 AM, Eric Sandeen wrote: > Close fd before we return on error paths. > > Resolves-Coverity-CID: 1125939 > Signed-off-by: Eric Sandeen > --- > utils.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/utils.c b/utils.c > index c11a7c2..c784345 100644 > --- a/utils.c > +++ b/utils.c > @@ -1905,10 +1905,12 @@ int test_dev_for_mkfs(char *file, int force_overwrite, char *estr) > if (fstat(fd, &st)) { > snprintf(estr, sz, "unable to stat %s: %s\n", file, > strerror(errno)); > + close(fd); > return 1; > } > if (!S_ISBLK(st.st_mode)) { > fprintf(stderr, "'%s' is not a block device\n", file); > + close(fd); > return 1; > } > close(fd); >