From: Jeff Mahoney <jeffm@suse.com>
To: Chris Mason <chris.mason@fusionio.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Kees Cook <keescook@chromium.org>,
Josef Bacik <JBacik@fusionio.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: fs/btrfs/extent-tree.c:8430:9: error: format not a string literal and no format arguments
Date: Wed, 20 Nov 2013 13:05:10 -0500 [thread overview]
Message-ID: <528CF9D6.1000903@suse.com> (raw)
In-Reply-To: <20131120173044.5312.44850@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]
On 11/20/13, 12:30 PM, Chris Mason wrote:
> Quoting Fengguang Wu (2013-11-19 23:05:51)
>> On Tue, Nov 19, 2013 at 07:56:35PM -0800, Kees Cook wrote:
>>> Hi!
>>>
>>> Which tree is 'devel-snb'? I don't see that on the kernel.org trees.
>>
>> It's my local merge branch, based on the latest upstream release.
>>
>> Let's CC the btrfs developers for this warning. :)
>>
>> Thanks,
>> Fengguang
>>
>>> On Tue, Nov 19, 2013 at 5:01 PM, kbuild test robot
>>> <fengguang.wu@intel.com> wrote:
>>>> tree: devel-snb-x86_64-201311200240
>>>> head: 1a985a0807ea34f37a4c5287089abd1cd2f65049
>>>> commit: a9b93a3684dd6ebfb7cfa173f78a79c09de81207 Merge 'kees/format-security' into devel-snb-x86_64-201311200240
>>>> date: 6 hours ago
>>>> config: make ARCH=x86_64 allmodconfig
>>>>
>>>> All error/warnings:
>>>>
>>>> fs/btrfs/extent-tree.c:6201:12: sparse: symbol 'get_raid_name' was not declared. Should it be static?
>>>> fs/btrfs/extent-tree.c:2469:28: sparse: context imbalance in 'run_clustered_refs' - unexpected unlock
>>>> fs/btrfs/extent-tree.c:8304:9: sparse: context imbalance in 'btrfs_put_block_group_cache' - wrong count at exit
>>>> fs/btrfs/extent-tree.c: In function '__link_block_group':
>>>>>> fs/btrfs/extent-tree.c:8430:9: error: format not a string literal and no format arguments [-Werror=format-security]
>>>> get_raid_name(index));
>
> This comes from the btrfs-next tree, with Jeff's sysfs patches, so I've
> added Jeff.
Thanks for the heads up. I have a few other fixes that need to go into
that patch set WRT cleanup too.
-Jeff
--
Jeff Mahoney
SUSE Labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 841 bytes --]
next prev parent reply other threads:[~2013-11-20 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528c09f9.S0ecVwNN2c+fnUkv%fengguang.wu@intel.com>
[not found] ` <CAGXu5jLoG00u2svBW6W5h9QsfYw1zZwYhZ1k4HG2UsvcWPHxuQ@mail.gmail.com>
2013-11-20 4:05 ` fs/btrfs/extent-tree.c:8430:9: error: format not a string literal and no format arguments Fengguang Wu
2013-11-20 16:04 ` Kees Cook
2013-11-21 1:03 ` Fengguang Wu
2013-11-20 17:30 ` Chris Mason
2013-11-20 18:05 ` Jeff Mahoney [this message]
2013-11-20 18:37 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528CF9D6.1000903@suse.com \
--to=jeffm@suse.com \
--cc=JBacik@fusionio.com \
--cc=chris.mason@fusionio.com \
--cc=fengguang.wu@intel.com \
--cc=keescook@chromium.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).