From: Miao Xie <miaox@cn.fujitsu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] xfstests,btrfs: add wrong compress type regression test
Date: Tue, 26 Nov 2013 15:01:46 +0800 [thread overview]
Message-ID: <5294475A.3000703@cn.fujitsu.com> (raw)
In-Reply-To: <20131126064107.GN8803@dastard>
On tue, 26 Nov 2013 17:41:07 +1100, Dave Chinner wrote:
> On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote:
>> Btrfs would crash when the users wrote some data into a file with compress
>> flag but the compression of the fs was disabled. This test case is to check
>> this bug still happen or not.
>>
>> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
>> ---
>> Changlog v1 -> v2:
>> - address the commit from Dave Chinner.
>
> Testing every change before posting them for review is a good habit
> to develop. This:
>
>> + $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io
>
> will dump this:
>
> wrote 1048576/1048576 bytes at offset 0
> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> command "sync" not found
>
> into the output file and hence the test will fail as the golden
> image file in the patch was not updated to match the new test output.
>
> It also points out that "-c sync" command is invalid - the
> command to fsync a file is "-c fsync".
Sorry for my miss, please review the 3th one.
Thanks
Miao
>
> Cheers,
>
> Dave.
>
prev parent reply other threads:[~2013-11-26 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 10:28 [PATCH] xfstests,btrfs: add wrong compress type regression test Miao Xie
2013-11-25 21:00 ` Dave Chinner
2013-11-26 6:01 ` [PATCH v2] " Miao Xie
2013-11-26 6:41 ` Dave Chinner
2013-11-26 7:00 ` [PATCH v3] " Miao Xie
2013-11-27 4:14 ` Dave Chinner
2013-11-26 7:01 ` Miao Xie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5294475A.3000703@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).