From: Anand Jain <Anand.Jain@oracle.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org, clm@fb.com,
Alex Lyakas <alex.btrfs@zadarastorage.com>
Subject: Re: [PATCH] btrfs-progs: add options to sync filesystem after subvol delete
Date: Fri, 29 Nov 2013 16:05:08 +0800 [thread overview]
Message-ID: <52984AB4.2020806@oracle.com> (raw)
In-Reply-To: <1385657947-26145-1-git-send-email-dsterba@suse.cz>
> If the command with sync option finishes succesfully, the subvolume(s)
> deletion status is safely stored on the media.
> + if (sync_mode == 1) {
> + res = ioctl(fd, BTRFS_IOC_SYNC);
> + if (res < 0) {
> + fprintf(stderr,
> + "ERROR: unable to sync after '%s': %s\n",
> + path, strerror(e));
> + ret = 1;
> + }
> + }
> +
generalized sync isn't too viable option in all production environment
as it would disturb the steady state performance in some environment.
prev parent reply other threads:[~2013-11-29 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 16:59 [PATCH] btrfs-progs: add options to sync filesystem after subvol delete David Sterba
2013-11-28 19:36 ` Roman Mamedov
2013-11-29 2:04 ` Wang Shilong
2013-11-29 17:37 ` David Sterba
2013-12-02 9:02 ` Wang Shilong
2013-12-09 23:32 ` David Sterba
2013-12-10 13:17 ` Chris Mason
2013-12-10 17:36 ` David Sterba
2013-12-10 18:24 ` Chris Mason
2013-12-12 18:07 ` David Sterba
2013-11-29 5:13 ` Miao Xie
2013-11-29 17:05 ` David Sterba
2013-11-29 8:05 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52984AB4.2020806@oracle.com \
--to=anand.jain@oracle.com \
--cc=alex.btrfs@zadarastorage.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).